1164852 - some of the reference files for float-in-rtl-* reftests do not render properly

Status: RESOLVED FIXED

(Core :: Layout: Floats, defect)

Description

[Jonathan Kew [:jfkthame]]

It's come to my attention that some of the reference files here don't actually render as intended in the vertical writing-mode tests, mainly due to the use of position:relative, which doesn't work right in all cases.

(FWIW, a bunch of them render incorrectly in Chrome, too. It's not just us!)

Anyway, to make the tests more reliable/meaningful, I propose to rewrite the reference files using basic layout features (margin/padding) to put the elements in the expected positions. This makes them render as intended (also in Chrome), so that the reftests will be more useful as we work on the positioning issues that still affect a number of the testcases.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Rewrite reference files for float-in-rtl-* reftests to avoid the use of position:relative

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: patch 2 - Remove irrelevant position:relative from all the float-in-rtl-* testcases, too

While we're here, let's remove position:relative (with no offsets) from all the testcases, too; it's serving no real purpose, though it does affect painting order (and that's why I had to reorder elements in a couple of the reference files in the preceding patch; this lets them be returned to their original order).

Comment 3

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad45f127935b

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 8605841 [details] [diff] [review]
Rewrite reference files for float-in-rtl-* reftests to avoid the use of position:relative

Review of attachment 8605841 [details] [diff] [review]:
-----------------------------------------------------------------

Ah good, this removes the UNEXPECTED-PASS that I had my doubts about in bug 1147834 comment 8

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 8605845 [details] [diff] [review]
patch 2 - Remove irrelevant position:relative from all the float-in-rtl-* testcases, too

Review of attachment 8605845 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 6

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcd85a531d88
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8388514b0ea

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fcd85a531d88
https://hg.mozilla.org/mozilla-central/rev/a8388514b0ea