1164867 - b2g desktop builds not checking out source

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Michael Shal [:mshal]]

In bug 1162171, checkout-sources was split out as a separate action instead of during preflight_build. However, we forgot to update the b2g desktop configs, which are also affected since B2GDesktopBuild inherits from FxDesktopBuild. This means b2g desktop builds aren't actually checking out or updating the source tree.

Comment 1

[Michael Shal [:mshal]]

Attachment: b2g-desktop-checkout

Assuming try passes and actually checks out the right revision of the tree:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad99fd42f710

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1921889
repository: b2g-inbound
start_time: 2015-05-14T07:02:09
who: mshal[at]mozilla[dot]com
machine: bld-lion-r5-092
buildname: b2g_b2g-inbound_macosx64_gecko build
revision: 4ed00abd04f0

"abs_src_mozconfig" path could not be determined. Please make sure it is a valid path off of "abs_src_dir"
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1921714
repository: b2g-inbound
start_time: 2015-05-14T05:30:04
who: mshal[at]mozilla[dot]com
machine: bld-lion-r5-073
buildname: b2g_b2g-inbound_macosx64_gecko build
revision: 4ed00abd04f0

"abs_src_mozconfig" path could not be determined. Please make sure it is a valid path off of "abs_src_dir"
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1921893
repository: b2g-inbound
start_time: 2015-05-14T07:18:28
who: mshal[at]mozilla[dot]com
machine: bld-lion-r5-068
buildname: b2g_b2g-inbound_macosx64_gecko build
revision: a28a9be738ee

"abs_src_mozconfig" path could not be determined. Please make sure it is a valid path off of "abs_src_dir"
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1921713
repository: b2g-inbound
start_time: 2015-05-14T05:30:28
who: mshal[at]mozilla[dot]com
machine: b-2008-ix-0146
buildname: b2g_b2g-inbound_win32_gecko build
revision: 4ed00abd04f0

"abs_src_mozconfig" path could not be determined. Please make sure it is a valid path off of "abs_src_dir"
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1921708
repository: b2g-inbound
start_time: 2015-05-14T05:30:04
who: mshal[at]mozilla[dot]com
machine: b-2008-ix-0127
buildname: b2g_b2g-inbound_win32_gecko-debug build
revision: 4ed00abd04f0

"abs_src_mozconfig" path could not be determined. Please make sure it is a valid path off of "abs_src_dir"
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1922018
repository: b2g-inbound
start_time: 2015-05-14T08:31:35
who: mshal[at]mozilla[dot]com
machine: bld-lion-r5-057
buildname: b2g_b2g-inbound_macosx64_gecko build
revision: d4b56d523d67

"abs_src_mozconfig" path could not be determined. Please make sure it is a valid path off of "abs_src_dir"
Running post_fatal callback...
setting return code to 2 because fatal was called
Exiting -1
# TBPL FAILURE #
# TBPL FAILURE #

Comment 8

[Jordan Lund (:jlund)]

Comment on attachment 8605856 [details] [diff] [review]
b2g-desktop-checkout

Review of attachment 8605856 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is all we need to change. There might be a stray platform config but it will likely stand out like a sore thumb when it doesn't have any source checked out ;)

Comment 9

[Michael Shal [:mshal]]

https://hg.mozilla.org/build/mozharness/rev/80e0e34911c1
https://hg.mozilla.org/integration/b2g-inbound/rev/cdd74fdcfaf1

Hopefully it stands out if so... unfortunately if the source tree hasn't been clobbered, we'll happily build with the previously checked out tree (using the wrong revision).

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cdd74fdcfaf1