In a number of places we depend on a fixed status bar height of 20 points. This breaks if the status bar height changes. For example when you enable Personal Hotspot on an iPhone, the status bar will be 40 points high and most of our layouts break.
This probably isn't blocking by itself, but it sounds like this is causing problems that are blocking.
Created attachment 8608775 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/485 Removed the hardcoded status bar heights everywhere except for the TabTrayController which will come as part of the refactor branch
Comment on attachment 8608775 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/485 This looks pretty good. One thing I found: In the simulator when I toggle the In-Call Status Bar (which is a double height status bar), the tab tray controller is correctly pushed down to make room, but it never goes back up when the bar goes away. This does work in the browserviewcontroller.
Created attachment 8609398 [details] [diff] [review] Commit Added a notification listener for whenever the status bar frame changes so we can update the layout accordingly.
Comment on attachment 8609398 [details] [diff] [review] Commit Awesome!