1164897 - Remove hardcoded status bar height

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

In a number of places we depend on a fixed status bar height of 20 points. This breaks if the status bar height changes. For example when you enable Personal Hotspot on an iPhone, the status bar will be 40 points high and most of our layouts break.

Comment 1

[Wesley Johnston (:wesj)]

This probably isn't blocking by itself, but it sounds like this is causing problems that are blocking.

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/485

Removed the hardcoded status bar heights everywhere except for the TabTrayController which will come as part of the refactor branch

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8608775 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/485

This looks pretty good. One thing I found: In the simulator when I toggle the In-Call Status Bar (which is a double height status bar), the tab tray controller is correctly pushed down to make room, but it never goes back up when the bar goes away. This does work in the browserviewcontroller.

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: Commit

Added a notification listener for whenever the status bar frame changes so we can update the layout accordingly.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8609398 [details] [diff] [review]
Commit

Awesome!

Comment 6

[Stephan Leroux [:sleroux]]

Merged