Closed Bug 1164940 Opened 10 years ago Closed 10 years ago

Remove pocket iframe from panelUI.inc and insert it when the view is initially created

Categories

(Firefox :: Pocket, defect)

Product:
Firefox
Component:
Pocket
Version:
38 Branch
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 41
Iteration:
41.1 - May 25
Tracking Flags:
Tracking Status
firefox38.0.5 --- verified
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1164940 - lazily create iframe, r?jaws
39 bytes, text/x-review-board-request
jaws
: review+
Details
No description provided.
Attached file MozReview Request: bz://1164940/Gijs (obsolete) —
/r/8775 - Bug 1164940 - lazily create iframe, r?jaws Pull down this commit: hg pull -r 3042a883a8bd4d5faec3a13d00363d250d44af39 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8605981 - Flags: review?(jaws)
Comment on attachment 8605981 [details] MozReview Request: bz://1164940/Gijs https://reviewboard.mozilla.org/r/8773/#review7471 Ship It!
Attachment #8605981 - Flags: review?(jaws) → review+
Comment on attachment 8605981 [details] MozReview Request: bz://1164940/Gijs Approval Request Comment [Feature/regressing bug #]: pocket [User impact if declined]: perf! [Describe test coverage new/current, TreeHerder]: hopefully this would cause test failures if it broke opening the panel. I did also test this locally [Risks and why]: low/none, unless I missed something that relies on the iframe (grep indicates I did not, and it worked locally, but who knows...) [String/UUID change made/needed]: nope
Attachment #8605981 - Flags: approval-mozilla-release?
Attachment #8605981 - Flags: approval-mozilla-beta?
Attachment #8605981 - Flags: approval-mozilla-aurora?
Iteration: --- → 41.1 - May 25
Points: --- → 2
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/80b9c8af0d35
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8605981 [details] MozReview Request: bz://1164940/Gijs Should be in 38.0.5b3.
Attachment #8605981 - Flags: approval-mozilla-release?
Attachment #8605981 - Flags: approval-mozilla-release+
Attachment #8605981 - Flags: approval-mozilla-beta?
Attachment #8605981 - Flags: approval-mozilla-beta+
Attachment #8605981 - Flags: approval-mozilla-aurora?
Attachment #8605981 - Flags: approval-mozilla-aurora+
Gijs, I verified using Firefox 38.0.5 beta 3 under all platforms that the Pocket panel looks good and there are no UI/functional issues. Is there something else I should cover for this verification? Thank you!
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Petruta Rasa [QA] [:petruta] from comment #10) > Gijs, I verified using Firefox 38.0.5 beta 3 under all platforms that the > Pocket panel looks good and there are no UI/functional issues. Is there > something else I should cover for this verification? Thank you! Nope, that sounds good to me. Thanks!
Status: RESOLVED → VERIFIED
status-firefox38.0.5: fixed → verified
Flags: needinfo?(gijskruitbosch+bugs)
Removing qe-verify+ since verification on 38.0.5 Beta should suffice.
Flags: qe-verify+
Attachment #8605981 - Attachment is obsolete: true
Attachment #8620297 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: