Remove pocket iframe from panelUI.inc and insert it when the view is initially created

VERIFIED FIXED in Firefox 38.0.5

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

38 Branch
Firefox 41
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite -

Firefox Tracking Flags

(firefox38.0.5 verified, firefox39 fixed, firefox40 fixed, firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

4 years ago
No description provided.
Assignee

Comment 1

4 years ago
/r/8775 - Bug 1164940 - lazily create iframe, r?jaws

Pull down this commit:

hg pull -r 3042a883a8bd4d5faec3a13d00363d250d44af39 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8605981 - Flags: review?(jaws)
Comment on attachment 8605981 [details]
MozReview Request: bz://1164940/Gijs

https://reviewboard.mozilla.org/r/8773/#review7471

Ship It!
Attachment #8605981 - Flags: review?(jaws) → review+
Assignee

Comment 4

4 years ago
Comment on attachment 8605981 [details]
MozReview Request: bz://1164940/Gijs

Approval Request Comment
[Feature/regressing bug #]: pocket
[User impact if declined]: perf!
[Describe test coverage new/current, TreeHerder]: hopefully this would cause test failures if it broke opening the panel. I did also test this locally
[Risks and why]: low/none, unless I missed something that relies on the iframe  (grep indicates I did not, and it worked locally, but who knows...)
[String/UUID change made/needed]: nope
Attachment #8605981 - Flags: approval-mozilla-release?
Attachment #8605981 - Flags: approval-mozilla-beta?
Attachment #8605981 - Flags: approval-mozilla-aurora?
Assignee

Updated

4 years ago
Iteration: --- → 41.1 - May 25
Points: --- → 2
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Assignee

Updated

4 years ago
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/80b9c8af0d35
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8605981 [details]
MozReview Request: bz://1164940/Gijs

Should be in 38.0.5b3.
Attachment #8605981 - Flags: approval-mozilla-release?
Attachment #8605981 - Flags: approval-mozilla-release+
Attachment #8605981 - Flags: approval-mozilla-beta?
Attachment #8605981 - Flags: approval-mozilla-beta+
Attachment #8605981 - Flags: approval-mozilla-aurora?
Attachment #8605981 - Flags: approval-mozilla-aurora+
Gijs, I verified using Firefox 38.0.5 beta 3 under all platforms that the Pocket panel looks good and there are no UI/functional issues. Is there something else I should cover for this verification? Thank you!
Flags: needinfo?(gijskruitbosch+bugs)
Assignee

Comment 11

4 years ago
(In reply to Petruta Rasa [QA] [:petruta] from comment #10)
> Gijs, I verified using Firefox 38.0.5 beta 3 under all platforms that the
> Pocket panel looks good and there are no UI/functional issues. Is there
> something else I should cover for this verification? Thank you!

Nope, that sounds good to me. Thanks!
Status: RESOLVED → VERIFIED
Flags: needinfo?(gijskruitbosch+bugs)
Removing qe-verify+ since verification on 38.0.5 Beta should suffice.
Flags: qe-verify+
Assignee

Comment 13

4 years ago
Attachment #8605981 - Attachment is obsolete: true
Attachment #8620297 - Flags: review+
You need to log in before you can comment on or make changes to this bug.