1165047 - View-Source links at right of Browser Console trigger "DEPRECATION WARNING: The arguments you're passing to viewSource.xul are using an out-of-date API."

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Open Browser Console (ctrl+shift+J)

 2. Click any link on the right of an error/warning.
   (For example, you could load this URL in your browser:
     data:text/html,hello
    ...and then click the "data:" link that appears to the right
    of a character encoding warning in the Browser Console.)

 3. Look at the Browser Console again, after the "view source" window appears.

ACTUAL RESULTS: This warning:
{
DEPRECATION WARNING: The arguments you're passing to viewSource.xul are using an out-of-date API.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/Add-ons/Code_snippets/ViewSource
chrome://global/content/viewSource.js 329 _loadViewSourceDeprecated
chrome://global/content/viewSource.js 296 onXULLoaded
chrome://global/content/viewSource.js 163 handleEvent
null 0 null
}

This deprecation warning was added in bug 1025146.

EXPECTED RESULTS: No such warning. (i.e. the browser console code should update to be invoking view-source the New Way)

Comment 1

[Daniel Holbert [:dholbert]]

(I hit this in current Nightly, fwiw -- 41.0a1 (2015-05-14))

Comment 2

[Mike Conley (:mconley) (:⚙️)]

We're likely to uplift bug 1025146 to 40 as foundation for view source in a tab, so this will likely need to track.

But this _should_ be a pretty straight forward migration.

jryans - did you want this? Or should I do it?

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I'll look into this after my in tab work in bug 1067325.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This was fixed by the DevTools changes in bug 1067325.