URL's with parameters confuse XPInstall

VERIFIED FIXED in mozilla0.9.9

Status

Core Graveyard
Installer: XPInstall Engine
VERIFIED FIXED
17 years ago
2 years ago

People

(Reporter: David Einstein, Assigned: dveditz)

Tracking

Trunk
mozilla0.9.9

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.7+)
Gecko/20011221
BuildID:    2001122103

XPInstall uses everything after the ? in a url for it's own nefarious purposes.
 This makes it difficult to load a .xpi from a url that has parameters like a
bugzilla attachment.

Reproducible: Always
Steps to Reproduce:
1. Load the url 
2. Note the missing parameters in the name.
3. Click install.
4. Look at the install.log and note the -207 error

Actual Results:  The install fails because the xpinstaller could not open the url.

Expected Results:  Moziila should have flawlessly installed a shiny new kinda,
almost, sort of but probably not, bug free spell checker.

Comment 1

17 years ago
Adding Grace to Cc.

Comment 2

16 years ago
--> dveditz
Assignee: syd → dveditz
Target Milestone: --- → Future
(Assignee)

Comment 3

16 years ago
That's where this bug went... I have a fix for this in my tree.
Target Milestone: Future → mozilla0.9.9

Comment 4

16 years ago
Nominating for beta.  Dan has a fix so he claims.  We should handle urls and
parameters, so we do the proper installation.
Keywords: nsbeta1

Comment 5

16 years ago
Resetting milestone, only nsbeta1+ bugs can have a milestone on them, these are
niminated, but not yet plussed.
Target Milestone: mozilla0.9.9 → ---

Comment 6

16 years ago
only nsbeta1+ bugs can have milestones, resetting to ---

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: nsbeta1 → nsbeta1-

Updated

16 years ago
Keywords: mozilla1.0
(Assignee)

Comment 7

16 years ago
Adding back milestone, I already had a patch for this in my tree.
Keywords: patch
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 8

16 years ago
Created attachment 69686 [details] [diff] [review]
a fix

Comment 9

16 years ago
Comment on attachment 69686 [details] [diff] [review]
a fix

r=dprice
Attachment #69686 - Flags: review+

Comment 10

16 years ago
Comment on attachment 69686 [details] [diff] [review]
a fix

sr=mscott
Attachment #69686 - Flags: superreview+
(Assignee)

Comment 11

16 years ago
patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 12

16 years ago
Reassigning QA Contact to Grace.  Let me know if you need help with this one. 
a_trigger_args.html is a good place to start.
QA Contact: jimmylee → gbush

Comment 13

16 years ago
verified on 3/11 builds on all platforms
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.