116512 - URL's with parameters confuse XPInstall

Status: VERIFIED FIXED

Description

[David Einstein]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.7+)
Gecko/20011221
BuildID:    2001122103

XPInstall uses everything after the ? in a url for it's own nefarious purposes.
 This makes it difficult to load a .xpi from a url that has parameters like a
bugzilla attachment.

Reproducible: Always
Steps to Reproduce:
1. Load the url 
2. Note the missing parameters in the name.
3. Click install.
4. Look at the install.log and note the -207 error

Actual Results:  The install fails because the xpinstaller could not open the url.

Expected Results:  Moziila should have flawlessly installed a shiny new kinda,
almost, sort of but probably not, bug free spell checker.

Comment 1

[Jimmy Lee]

Adding Grace to Cc.

Comment 2

[Syd Logan]

--> dveditz

Comment 3

[Daniel Veditz [:dveditz]]

That's where this bug went... I have a fix for this in my tree.

Comment 4

[Jimmy Lee]

Nominating for beta.  Dan has a fix so he claims.  We should handle urls and
parameters, so we do the proper installation.

Comment 5

[Syd Logan]

Resetting milestone, only nsbeta1+ bugs can have a milestone on them, these are
niminated, but not yet plussed.

Comment 6

[Syd Logan]

only nsbeta1+ bugs can have milestones, resetting to ---

Comment 7

[Daniel Veditz [:dveditz]]

Adding back milestone, I already had a patch for this in my tree.

Comment 8

[Daniel Veditz [:dveditz]]

Created attachment 69686 [details] [diff] [review]
a fix

Comment 9

[dprice (gone)]

Comment on attachment 69686 [details] [diff] [review]
a fix

r=dprice

Comment 10

[Scott MacGregor]

Comment on attachment 69686 [details] [diff] [review]
a fix

sr=mscott

Comment 11

[Daniel Veditz [:dveditz]]

patch checked in.

Comment 12

[Jimmy Lee]

Reassigning QA Contact to Grace.  Let me know if you need help with this one. 
a_trigger_args.html is a good place to start.

Comment 13

[Grace Bush]

verified on 3/11 builds on all platforms