Closed Bug 116512 Opened 24 years ago Closed 23 years ago

URL's with parameters confuse XPInstall

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: Deinst, Assigned: dveditz)

References

(
URL
)

Details

Attachments

(1 file)

a fix
1.82 KB, patch
dprice
: review+
mscott
: superreview+
Details | Diff | Splinter Review
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.7+) Gecko/20011221 BuildID: 2001122103 XPInstall uses everything after the ? in a url for it's own nefarious purposes. This makes it difficult to load a .xpi from a url that has parameters like a bugzilla attachment. Reproducible: Always Steps to Reproduce: 1. Load the url 2. Note the missing parameters in the name. 3. Click install. 4. Look at the install.log and note the -207 error Actual Results: The install fails because the xpinstaller could not open the url. Expected Results: Moziila should have flawlessly installed a shiny new kinda, almost, sort of but probably not, bug free spell checker.
Adding Grace to Cc.
--> dveditz
Assignee: syd → dveditz
Target Milestone: --- → Future
That's where this bug went... I have a fix for this in my tree.
Target Milestone: Future → mozilla0.9.9
Nominating for beta. Dan has a fix so he claims. We should handle urls and parameters, so we do the proper installation.
Keywords: nsbeta1
Resetting milestone, only nsbeta1+ bugs can have a milestone on them, these are niminated, but not yet plussed.
Target Milestone: mozilla0.9.9 → ---
only nsbeta1+ bugs can have milestones, resetting to ---
Status: NEW → ASSIGNED
Keywords: nsbeta1 → nsbeta1-
Keywords: mozilla1.0
Adding back milestone, I already had a patch for this in my tree.
Keywords: patch
Target Milestone: --- → mozilla0.9.9
Attached patch a fix — — Splinter Review
Comment on attachment 69686 [details] [diff] [review] a fix r=dprice
Attachment #69686 - Flags: review+
Comment on attachment 69686 [details] [diff] [review] a fix sr=mscott
Attachment #69686 - Flags: superreview+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reassigning QA Contact to Grace. Let me know if you need help with this one. a_trigger_args.html is a good place to start.
QA Contact: jimmylee → gbush
verified on 3/11 builds on all platforms
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: