1165128 - Enable zoomed view on Nightly builds

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It's looking really refined to me! Good work, Dominique!

Let's get this out on Nightly by removing the about:config toggle (but don't let it ship to release builds just yet)!

Once bug 1135369 is ironed out, I think we'll be pretty close to shipping it! :D

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Agree, great work Dominique!

Keep in mind, depending on how intuitively this triggers... we might need a pref in Settings. :)

Comment 2

[Dominique Vincent [:domivinc]]

Attachment: patch-15052015 1-Bug_1165128___Enable_zoomedview_by_default__r_mcomella.patch

Michael, I share the point from Anthony's comment. So I replaced the Pref "ui.zoomedview.enabled" by "ui.zoomedview.disabled". The user will still have the possibility to disable the zoomed view.

For the mobile devices loading the file "mobile/android/app/mobile.js", the zoomed view is now by default enabled. 
For all the other mobile devices using only "layout/base/PositionedEventTargeting.cpp", the zoomed view is still never enabled.

This change will impact all the nightly Android users. By default they will have the zoomed view enabled whatever the value they previously entered in "ui.zoomedview.enabled".

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8606484 [details] [diff] [review]
patch-15052015 1-Bug_1165128___Enable_zoomedview_by_default__r_mcomella.patch

Review of attachment 8606484 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Let's land this, Dominique! :)

Comment 4

[Dominique Vincent [:domivinc]]

https://tbpl.mozilla.org/?tree=Try&rev=1d5cd8188352

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/12df4e64ecc3

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/12df4e64ecc3

Comment 7

[Kartikaya Gupta (email:[e-mail])]

This is awesome! Feels like it does a great job of deciding when to pop up the zoomed view and when not to.