Closed Bug 1165128 Opened 5 years ago Closed 5 years ago

Enable zoomed view on Nightly builds

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: mcomella, Assigned: domivinc, Mentored)

References

Details

(Whiteboard: [only enabled on Nightly])

Attachments

(1 file)

It's looking really refined to me! Good work, Dominique!

Let's get this out on Nightly by removing the about:config toggle (but don't let it ship to release builds just yet)!

Once bug 1135369 is ironed out, I think we'll be pretty close to shipping it! :D
No longer blocks: zoomedview
Depends on: zoomedview
Agree, great work Dominique!

Keep in mind, depending on how intuitively this triggers... we might need a pref in Settings. :)
Michael, I share the point from Anthony's comment. So I replaced the Pref "ui.zoomedview.enabled" by "ui.zoomedview.disabled". The user will still have the possibility to disable the zoomed view.

For the mobile devices loading the file "mobile/android/app/mobile.js", the zoomed view is now by default enabled. 
For all the other mobile devices using only "layout/base/PositionedEventTargeting.cpp", the zoomed view is still never enabled.

This change will impact all the nightly Android users. By default they will have the zoomed view enabled whatever the value they previously entered in "ui.zoomedview.enabled".
Attachment #8606484 - Flags: review?(michael.l.comella)
Comment on attachment 8606484 [details] [diff] [review]
patch-15052015 1-Bug_1165128___Enable_zoomedview_by_default__r_mcomella.patch

Review of attachment 8606484 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Let's land this, Dominique! :)
Attachment #8606484 - Flags: review?(michael.l.comella) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/12df4e64ecc3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
This is awesome! Feels like it does a great job of deciding when to pop up the zoomed view and when not to.
Whiteboard: [only enabled on Nightly]
You need to log in before you can comment on or make changes to this bug.