Closed Bug 1165129 Opened 9 years ago Closed 9 years ago

JsepSessionImpl will not handle JS reordering the codecs in a local answer, once we start emitting multiple

Categories

(Core :: WebRTC: Signaling, defect, P4)

Product:
Core
Component:
WebRTC: Signaling
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1165129: Allow JS to reorder codecs in a local answer. Also means that we'll take the ordering more seriously when we see multiple codecs in a remote answer. r=jesup
39 bytes, text/x-review-board-request
bwc
: review+
Details 
If we were to create an answer with multiple codecs on an m-line, and then JS rewrote to switch up the ordering, we would ignore that and pick our favorite from the offer once negotiation completed.
Attached file MozReview Request: bz://1165129/bwc (obsolete) — 
/r/8791 - Bug 1165129: Allow JS to reorder codecs in a local answer. Also means that we'll take the ordering more seriously when we see multiple codecs in a remote answer.

Pull down this commit:

hg pull -r 75c656dae6cda6602f85a5056a2b111730da1fc4 https://reviewboard-hg.mozilla.org/gecko/
not high priority, until another bug lands... but in future pull this.
backlog: --- → webRTC+
Rank: 45
Priority: -- → P4
Attachment #8606040 - Flags: review?(rjesup)
Comment on attachment 8606040 [details]
MozReview Request: bz://1165129/bwc

https://reviewboard.mozilla.org/r/8789/#review8023

I could swear I reviewed this before, but in any case...
Attachment #8606040 - Flags: review?(rjesup) → review+
Comment on attachment 8606040 [details]
MozReview Request: bz://1165129/bwc

/r/8791 - Bug 1165129: Allow JS to reorder codecs in a local answer. Also means that we'll take the ordering more seriously when we see multiple codecs in a remote answer. r=jesup

Pull down this commit:

hg pull -r 1cb48975b0d5cae7e7f04999b5d70f38b36ba53d https://reviewboard-hg.mozilla.org/gecko/
Attachment #8606040 - Flags: review+
Comment on attachment 8606040 [details]
MozReview Request: bz://1165129/bwc

Unrot, carry forward r=jesup. Need to check back on try.
Flags: needinfo?(docfaraday)
Attachment #8606040 - Flags: review+
Flags: needinfo?(docfaraday)
https://hg.mozilla.org/mozilla-central/rev/001de2286250
Assignee: nobody → docfaraday
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

        Attachment #8606040 -
        Attachment is obsolete: true

        Attachment #8620303 -
        Flags: review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: