1165137 - Remove `static` keyword from ChangeVerifier interface

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://mxr.mozilla.org/mozilla-central/search?string=interface%20changeverifier&find=mobile%2Fandroid&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Intellij tells me it's redundant for inner interfaces!

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

The code you would be fixing are in our Robocop test framework, so you'll need to set that up too: https://wiki.mozilla.org/Auto-tools/Projects/Robocop

When you make changes in the mobile/android/tests/browser/robocop directory, you should only need to recompile Robocop, not the entire browser, for these changes.

While you're developing, I recommend running just a single test at a time because the full robocop test suite takes a long time to run (at least 30 minutes).

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 1

[Neil Bleasdale [:nbleasdale]]

Attachment: bug_1165137.patch

I feel like I may be missing something here, but I've attached the patch. Robocop tests run OK too after my changes. Well, I say OK... they took one hour forty minutes on my hardware :/ but it all seems good.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8606993 [details] [diff] [review]
bug_1165137.patch

Review of attachment 8606993 [details] [diff] [review]:
-----------------------------------------------------------------

Hey, Neil! Thanks for the patch - it's what I was expecting.

> Robocop tests run OK too after my changes. Well, I say OK... they took one
> hour forty minutes on my hardware :/ but it all seems good.

I apologize for being unclear! Before your patch can get checked in (via the "checkin-needed" keyword: see below), the full suite has to be run on our try test servers so you don't have to worry about running the whole thing locally. You should only need to run the tests that are affected by your changes, or in the case of a mass change (like this), just a few of them.

The push to our try test servers is above.

Once it goes green, feel free to add the checkin-needed keyword [1]. Let me know if you need help reading the results.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87a9549a5ce8

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #2)
> The push to our try test servers is above.

By above, I mean below: comment 3.

Comment 5

[Neil Bleasdale [:nbleasdale]]

Ah, I see. That makes sense. So, as far as the try results go there's one blue in a sea of green. RC6. Does that mean it retried successfully? Or just that it needs retrying?

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

You can click the question mark at the top of the page for more information (it brings you to [1]).

Blue means the build was restarted, which usually occurs automatically after an infrastructure exception. Since rc6 passed once and there are no failures due to our code, it looks good to land!

By the way, you can use the "Need more information from" box below the comment field to give the user you'd like to talk to a notification - it's harder to lose track of. For example... 

[1]: https://treeherder.mozilla.org/help.html

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7fe81c61fe03

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Thanks, Neil! If you're looking for a follow-up bug, perhaps bug 1128561 or bug 1105271?

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7fe81c61fe03