1165145 - Incorrect MediaSource buffered range being reported in ended mode.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

The MediaSourceReader::GetBuffered() when in ended mode adjust the buffered range so they all end at the same level as the highest end time across source buffer.

This is wrong.

Only a sourcebuffer is to perform such alignment and across the trackbuffers.
(http://w3c.github.io/media-source/index.html#widl-SourceBuffer-buffered)

This cause webref mediasource-buffered.html to fail.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Part1. Never reports negative time ranges with MSE

We could report time ranges such as [-1 0] as GetEndTime on an empty TimeRanges return -1

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Part2. Only extends source buffer ranges if non-empty

Take "If readyState is ended, then set the end time on the last range in source ranges to highest end time." literally. That is is there s no last range, there s nothing to set.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Part3. Update webref results

Update webref

Comment 4

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dd9121994e1

got a previous green try, but made some changes up the chain so redoing them just in case.

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8606083 [details] [diff] [review]
Part1. Never reports negative time ranges with MSE

I had assumed from the commit message that this was meant to remove an existing negative time range, and so it took me a while to work out that this is to prevent adding a (-1,0) time range here because TimeRanges::GetEndTime() returns -1 when there are no ranges, while TrackBuffer::Buffered() returns 0.

Can you change the comment to say "don't add a negative time range to empty buffered ranges" or similar, please?

An alternative fix, possibly making the code easier to follow would be to make Buffered() return -1, like GetEndTime().  However, I guess this is being rewritten in bug 1163445 anyway.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b24663ec60e
https://hg.mozilla.org/integration/mozilla-inbound/rev/3017514d76f3
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb3eb37c2e2b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4b24663ec60e
https://hg.mozilla.org/mozilla-central/rev/3017514d76f3
https://hg.mozilla.org/mozilla-central/rev/bb3eb37c2e2b