Closed
Bug 1165264
Opened 10 years ago
Closed 10 years ago
Port test from |Bug 952982 - Submit inputs should be subject to constraint validation and match :valid/:invalid as needed| to SeaMonkey
Categories
(SeaMonkey :: Testing Infrastructure, defect)
SeaMonkey
Testing Infrastructure
Tracking
(firefox41 affected)
RESOLVED
FIXED
seamonkey2.38
Tracking | Status | |
---|---|---|
firefox41 | --- | affected |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
2.04 KB,
patch
|
philip.chee
:
review+
|
Details | Diff | Splinter Review |
At the moment test browser_bug581947.js fails with:
TEST-UNEXPECTED-FAIL | suite/browser/test/browser/browser_bug581947.js | No tooltip should be shown when the element is barred from constraint validation -
Stack trace:
chrome://mochitests/content/browser/suite/browser/test/browser/browser_bug581947.js:check:14
chrome://mochitests/content/browser/suite/browser/test/browser/browser_bug581947.js:loadListener:72
null:null:0
Need to port test from bug 952982
Attachment #8606232 -
Flags: review?(philip.chee)
Comment 1•10 years ago
|
||
Comment on attachment 8606232 [details] [diff] [review]
Fix test browser_bug581947.js [Checked in: Comment 2]
> + [ 'fieldset', true, null],
> + [ 'object', true, null],
nit: no comma.
anti-nit: I think ES6 allows for trailing commas.
> ];
> for each (let data in testData) {
> - check(data[0], data[1]);
> + check(data[0], data[1], data[2]);
nit: for (let data of testData) { ... }
Attachment #8606232 -
Flags: review?(philip.chee) → review+
Comment on attachment 8606232 [details] [diff] [review]
Fix test browser_bug581947.js [Checked in: Comment 2]
http://hg.mozilla.org/comm-central/rev/c97965845c1e
for-in to for-of changes are part of bug 1153671
Attachment #8606232 -
Attachment description: Fix test browser_bug581947.js → Fix test browser_bug581947.js [Checked in: Comment 2]
Assignee: nobody → iann_bugzilla
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•