Closed Bug 1165308 Opened 5 years ago Closed 5 years ago

Pointer lock cancel message is misaligned on Windows and Linux

Categories

(Firefox :: Theme, defect, trivial)

defect
Not set
trivial
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 41
Iteration:
41.1 - May 25
Tracking Status
firefox41 --- fixed

People

(Reporter: dao, Assigned: dao)

References

()

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #8606271 - Flags: review?(paolo.mozmail)
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8606271 [details] [diff] [review]
patch

I can clearly see the misalignment by trying the test page in Release versions on Windows and Linux, but not on Mac, so I think the CSS changes make sense.

Out of curiosity, why the same thing doesn't happen on Mac?
Attachment #8606271 - Flags: review?(paolo.mozmail) → review+
Because on OS X, we set different margins for <description> and <label>, so whenever you mix those elements and want them to be aligned, you need to adjust the margins. It's very annoying.
https://hg.mozilla.org/mozilla-central/rev/14545accf5a0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.