Closed Bug 1165361 Opened 6 years ago Closed 6 years ago

Talos profiling needs to be updated for the new profile JSON format

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla41

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(5 files)

Bug 1154115 changed the format, I need to update the parts of Talos that parse the JSON.
I made a other fixes that aren't strictly related to the new format, but I'll put them into this bug anyway.
:vladan is going to notify me when the normal server is fixed, then we can back out this change.
Attachment #8607731 - Flags: review?(jmaher)
Comment on attachment 8607731 [details] [diff] [review]
1-Bug_1165361___The_official_mozilla_symbol_server_is_broken_at_the_moment__use_the_fallback_instance_until_the_problem_is_fixed__r_jmaher.diff

Review of attachment 8607731 [details] [diff] [review]:
-----------------------------------------------------------------

is mocotoolsstaging a permanent thing?
Attachment #8607731 - Flags: review?(jmaher) → review+
Attachment #8607732 - Flags: review?(jmaher) → review+
Attachment #8607733 - Flags: review?(jmaher) → review+
Attachment #8607734 - Flags: review?(jmaher) → review+
Comment on attachment 8607735 [details] [diff] [review]
5-Bug_1165361___Add_support_for_symbolicating_profiles_with_the_version_3_profile_JSON_format__r_jmaher.diff

Review of attachment 8607735 [details] [diff] [review]:
-----------------------------------------------------------------

how long will we have to support v2 and v3 of the symbols?
Attachment #8607735 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #7)
> is mocotoolsstaging a permanent thing?

No. In fact, I now have access to production symbolapi.mozilla.org, so we don't even have to make the change
(In reply to Joel Maher (:jmaher) from comment #8)
> how long will we have to support v2 and v3 of the symbols?

I'd wait until bug 1154115 is on aurora, in case it gets backed out for some reason. Other than that, there's no real reason to support v2 here.
(In reply to Markus Stange [:mstange] from comment #12)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=9efa78a2b7a0
I canceled that one, it didn't include a 10.10 run.

Here are the two try pushes to watch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cdbf59ea52c (with profiling)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d36993f8d4b (without profiling)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.