1165361 - Talos profiling needs to be updated for the new profile JSON format

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Markus Stange [:mstange]]

Bug 1154115 changed the format, I need to update the parts of Talos that parse the JSON.

Comment 1

[Markus Stange [:mstange]]

I made a other fixes that aren't strictly related to the new format, but I'll put them into this bug anyway.

Comment 2

[Markus Stange [:mstange]]

Attachment: 1-Bug_1165361___The_official_mozilla_symbol_server_is_broken_at_the_moment__use_the_fallback_instance_until_the_problem_is_fixed__r_jmaher.diff

:vladan is going to notify me when the normal server is fixed, then we can back out this change.

Comment 3

[Markus Stange [:mstange]]

Attachment: 2-Bug_1165361___Get_rid_of_profile_compression_because_it_won_t_be_necessary_with_the_new_JSON_format__r_jmaher.diff

Comment 4

[Markus Stange [:mstange]]

Attachment: 3-Bug_1165361___Verify_expected_breakpad_ID_when_dumping_symbols_for_OS_X_system_libraries__to_make_sure_we_re_dumping_symbols_for_the_right_architecture__r_jmaher.diff

Comment 5

[Markus Stange [:mstange]]

Attachment: 4-Bug_1165361___Support_symbolicating_nested_subprocess_profiles__r_jmaher.diff

Comment 6

[Markus Stange [:mstange]]

Attachment: 5-Bug_1165361___Add_support_for_symbolicating_profiles_with_the_version_3_profile_JSON_format__r_jmaher.diff

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8607731 [details] [diff] [review]
1-Bug_1165361___The_official_mozilla_symbol_server_is_broken_at_the_moment__use_the_fallback_instance_until_the_problem_is_fixed__r_jmaher.diff

Review of attachment 8607731 [details] [diff] [review]:
-----------------------------------------------------------------

is mocotoolsstaging a permanent thing?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8607735 [details] [diff] [review]
5-Bug_1165361___Add_support_for_symbolicating_profiles_with_the_version_3_profile_JSON_format__r_jmaher.diff

Review of attachment 8607735 [details] [diff] [review]:
-----------------------------------------------------------------

how long will we have to support v2 and v3 of the symbols?

Comment 9

[Vladan Djeric (:vladan)]

(In reply to Joel Maher (:jmaher) from comment #7)
> is mocotoolsstaging a permanent thing?

No. In fact, I now have access to production symbolapi.mozilla.org, so we don't even have to make the change

Comment 10

[Markus Stange [:mstange]]

(In reply to Joel Maher (:jmaher) from comment #8)
> how long will we have to support v2 and v3 of the symbols?

I'd wait until bug 1154115 is on aurora, in case it gets backed out for some reason. Other than that, there's no real reason to support v2 here.

Comment 11

[Markus Stange [:mstange]]

https://hg.mozilla.org/build/talos/rev/22b73666a391
https://hg.mozilla.org/build/talos/rev/8f36885b2f62
https://hg.mozilla.org/build/talos/rev/583443cadfc7
https://hg.mozilla.org/build/talos/rev/3618f52d7d30

Comment 12

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9efa78a2b7a0

Comment 13

[Markus Stange [:mstange]]

(In reply to Markus Stange [:mstange] from comment #12)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=9efa78a2b7a0
I canceled that one, it didn't include a 10.10 run.

Here are the two try pushes to watch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cdbf59ea52c (with profiling)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d36993f8d4b (without profiling)