Closed Bug 1165392 Opened 6 years ago Closed 6 years ago

Fix some unboxed array bugs

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(5 files)

Attached patch patchSplinter Review
The attached patch fixes some bugs with unboxed arrays I found while testing.
Attachment #8606387 - Flags: review?(jdemooij)
The baseline SETELEM caches for unboxed arrays were never being used, and are pretty broken.
Assignee: nobody → bhackett1024
Attachment #8607239 - Flags: review?(jdemooij)
Some more code that is responsible for handling effectless lookups needs to be aware of unboxed arrays.
Attachment #8607240 - Flags: review?(jdemooij)
Add Ion caches for GETELEM and length GETPROP on unboxed arrays.
Attachment #8607241 - Flags: review?(jdemooij)
Attached patch optimize concatSplinter Review
Handle unboxed arrays in the Ion optimized version of array.concat
Attachment #8607242 - Flags: review?(jdemooij)
Comment on attachment 8606387 [details] [diff] [review]
patch

Review of attachment 8606387 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/MIR.h
@@ +7785,1 @@
>      bool congruentTo(const MDefinition* ins) const override {

congruentTo should check checkNative_ right?
Attachment #8606387 - Flags: review?(jdemooij) → review+
Attachment #8607239 - Flags: review?(jdemooij) → review+
Comment on attachment 8607240 [details] [diff] [review]
improve JIT lookups

Review of attachment 8607240 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsobj.cpp
@@ +2812,5 @@
>              }
> +        } else if (obj->is<UnboxedArrayObject>()) {
> +            if (obj->as<UnboxedArrayObject>().containsProperty(cx, id)) {
> +                *objp = obj;
> +                MarkNonNativePropertyFound<NoGC>(propp);

Btw, is fixing the 0x1 shape thing still on your radar? :)
Attachment #8607240 - Flags: review?(jdemooij) → review+
Attachment #8607241 - Flags: review?(jdemooij) → review+
Attachment #8607242 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/57dce88fc620
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.