Switch unlocalizable "Example Title" to "mozilla.org"

VERIFIED FIXED in Firefox 40

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

(Blocks 1 bug)

Trunk
Firefox 41
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox40 verified, firefox41 verified)

Details

(Whiteboard: .?)

Attachments

(4 attachments)

Bug 1138818 landed with an unlocalizable example title string in the onboarding. We can avoid this by using a url: mozilla.org.
Posted patch v1Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8607232 - Flags: review?(adw)
Iteration: --- → 41.1 - May 25
Points: --- → 1
Blocks: 1145418
Attachment #8607232 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/1f2a768c819b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
We'll uplift this so that the string doesn't change from 39 to 40.
Blocks: 1140185
No longer blocks: 1145418
verified on Nightly - 41.0a1 (2015-05-26):

Steps to verify:
1. Opened up new Firefox profile using ProfileSwitcher
2. Firefox Nightly First Run Page appears
3. Opened up new tab by clicking on the "+"
4. Onboarding tutorial overlay appears over the tiles
5. The 1st and 2nd onboarding slide has correct tile title "mozilla.org" Screenshot attached.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Posted image Verified screenshot
Attachment #8610909 - Flags: review+
Flags: qe-verify+
Attachment #8610909 - Flags: review+
Comment on attachment 8610027 [details] [diff] [review]
for aurora (Mardak will land)

Approval Request Comment: See bug 1140185 comment 11
Attachment #8610027 - Flags: approval-mozilla-aurora?
Comment on attachment 8610027 [details] [diff] [review]
for aurora (Mardak will land)

approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610027 - Flags: approval-mozilla-aurora?
Confirming the fix on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit using latest Aurora, build ID: 20150528004000.
You need to log in before you can comment on or make changes to this bug.