Closed
Bug 1165430
Opened 9 years ago
Closed 9 years ago
Switch unlocalizable "Example Title" to "mozilla.org"
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: Mardak)
References
(Blocks 1 open bug)
Details
(Whiteboard: .?)
Attachments
(4 files)
1.33 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
1.34 KB,
patch
|
Details | Diff | Splinter Review | |
1.34 KB,
patch
|
Details | Diff | Splinter Review | |
414.32 KB,
image/png
|
Details |
Bug 1138818 landed with an unlocalizable example title string in the onboarding. We can avoid this by using a url: mozilla.org.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Iteration: --- → 41.1 - May 25
Points: --- → 1
Updated•9 years ago
|
Attachment #8607232 -
Flags: review?(adw) → review+
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1f2a768c819b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Assignee | ||
Comment 4•9 years ago
|
||
We'll uplift this so that the string doesn't change from 39 to 40.
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
Comment 7•9 years ago
|
||
verified on Nightly - 41.0a1 (2015-05-26): Steps to verify: 1. Opened up new Firefox profile using ProfileSwitcher 2. Firefox Nightly First Run Page appears 3. Opened up new tab by clicking on the "+" 4. Onboarding tutorial overlay appears over the tiles 5. The 1st and 2nd onboarding slide has correct tile title "mozilla.org" Screenshot attached.
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Flags: qe-verify+
Comment 8•9 years ago
|
||
Attachment #8610909 -
Flags: review+
Updated•9 years ago
|
Flags: qe-verify+
Assignee | ||
Updated•9 years ago
|
Attachment #8610909 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8610027 [details] [diff] [review] for aurora (Mardak will land) Approval Request Comment: See bug 1140185 comment 11
Attachment #8610027 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 10•9 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/b2de912de038
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8610027 [details] [diff] [review] for aurora (Mardak will land) approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610027 -
Flags: approval-mozilla-aurora?
Comment 12•9 years ago
|
||
Confirming the fix on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit using latest Aurora, build ID: 20150528004000.
You need to log in
before you can comment on or make changes to this bug.
Description
•