1165513 - gtk3 build form controls move around

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

Attachment: Screenshot from 2015-05-15 15-51-11.png

Form controls are floating around in the wrong position and drawing improperly.

This is a personal build off of
changeset:   244029:1a8343f8ed83
tag:         tip
parent:      243992:c0e709a5baca
parent:      244028:17042d4111bb
user:        Carsten "Tomcat" Book <[e-mail]>
date:        Fri May 15 17:39:23 2015 +0200
summary:     merge mozilla-inbound to mozilla-central  on a CLOSED TREE a=merge

.mozconfig
ac_add_options --enable-default-toolkit=cairo-gtk3
ac_add_options --enable-gstreamer=1.0
mk_add_options AUTOCLOBBER=1
export MOZILLA_OFFICIAL=1

I have layout.css.devPixelsPerPx set to 1.4 which may be relevant. It seems somewhat intermittent. E10S is turned off.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

It's HiDPI display, right? Something like https://bugzilla.redhat.com/show_bug.cgi?id=1215459#c8 ?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Correct.

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Translate GTK3 widgets with snapped pixel coordinates into identity space

When GTK3 widgets used snapped pixel coordinates, their coordinates are also relative to the origin, because they already went through the draw target's transform. However, the draw target matrix is not reset to identity to avoid messing with its state. To compensate, just translate the coordinates to invert the transform - legal since coordinates are only snapped if there is no scale and the transform is axis-aligned.

Comment 4

[Lee Salzman [:lsalzman]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #0)
> Created attachment 8606557 [details]
> Screenshot from 2015-05-15 15-51-11.png
> 
> Form controls are floating around in the wrong position and drawing
> improperly.
> 
> This is a personal build off of
> changeset:   244029:1a8343f8ed83
> tag:         tip
> parent:      243992:c0e709a5baca
> parent:      244028:17042d4111bb
> user:        Carsten "Tomcat" Book <[e-mail]>
> date:        Fri May 15 17:39:23 2015 +0200
> summary:     merge mozilla-inbound to mozilla-central  on a CLOSED TREE
> a=merge
> 
> .mozconfig
> ac_add_options --enable-default-toolkit=cairo-gtk3
> ac_add_options --enable-gstreamer=1.0
> mk_add_options AUTOCLOBBER=1
> export MOZILLA_OFFICIAL=1
> 
> I have layout.css.devPixelsPerPx set to 1.4 which may be relevant. It seems
> somewhat intermittent. E10S is turned off.

Can you check if my patch fixes the issue for you? It seems to fix the issue for me. I was able to reproduce the problem by narrowing it down to one particular branch where transforms weren't respected.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

Doing a build on the tip of m-c now. Will report back.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

This looks good after several hours of usage.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eac17f69772b

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eac17f69772b