1165585 - Enable MediaFormatReader with webaudio

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Web audio should be made to work with MediaFormatReader.

Only adaptation required would be to use AsyncReadMetadata instead of ReadMetadata.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Part1. Use AsyncReadmetadata with web audio

Use new AsyncReadMetadata API.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Part2. Use MediaFormatReader with web audio

Enable MediaFormatReader (for MP4) with web audio

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8606629 [details] [diff] [review]
Part1. Use AsyncReadmetadata with web audio

Review of attachment 8606629 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/webaudio/MediaBufferDecoder.cpp
@@ +265,5 @@
> +void
> +MediaDecodeTask::OnMetadataRead(MetadataHolder* aMetadata)
> +{
> +  mMediaInfo = aMetadata->mInfo;
> +  RequestSample();

You're removing the HasAudio() check, I don't think you should do that. Put it back.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Part1. Use AsyncReadmetadata with web audio

Rebasing and carrying r+

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4034a5e60515
https://hg.mozilla.org/integration/mozilla-inbound/rev/60eebe7251c4

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4034a5e60515
https://hg.mozilla.org/mozilla-central/rev/60eebe7251c4