[e10s] "Tab Preview" addon does not work

RESOLVED INCOMPLETE

Status

()

RESOLVED INCOMPLETE
3 years ago
10 months ago

People

(Reporter: tidus098, Unassigned)

Tracking

unspecified
x86_64
Linux
Points:
---

Firefox Tracking Flags

(e10s+)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8606687 [details]
Browse console when trying with addon

Addon Name: Tab Preview
Version: 0.3

Expected to happen:
When placing the cursor over a tab, show a popup preview

Actually happened:
Shows a blank popup
Ted, it looks like your Tab Preview add-on is not e10s compatible.
Blocks: 905436
tracking-e10s: --- → +
Flags: needinfo?(ted)
I'm not actively maintaining any of my addons, but TBH I'm kind of surprised this doesn't work! The meat of the extension boils down to calling ctx.drawWindow(window, ...) where ctx is a 2d Canvas context, and win is a tabbrowser.contentWindow. I put the source up on GitHub since apparently I didn't have it in VCS anywhere:
https://github.com/luser/tabpreview/blob/master/chrome/content/overlay.js#L227

I just installed it and tried it locally, and the console shows:
TabPreview Error: Argument 1 of CanvasRenderingContext2D.drawWindow does not implement interface Window.

so I guess contentWindow isn't really a Window?
Flags: needinfo?(ted)
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> I'm not actively maintaining any of my addons, but TBH I'm kind of surprised
> this doesn't work! The meat of the extension boils down to calling
> ctx.drawWindow(window, ...) where ctx is a 2d Canvas context, and win is a
> tabbrowser.contentWindow. I put the source up on GitHub since apparently I
> didn't have it in VCS anywhere:
> https://github.com/luser/tabpreview/blob/master/chrome/content/overlay.
> js#L227
> 
> I just installed it and tried it locally, and the console shows:
> TabPreview Error: Argument 1 of CanvasRenderingContext2D.drawWindow does not
> implement interface Window.
> 
> so I guess contentWindow isn't really a Window?

In this case, no, it is not - contentWindow is a CPOW.

I do recall us having problems with tab drag-and-drop thumbnails (which use the same technique, I believe). I just tested, and they still appear to be disabled, so I suspect we haven't solved that problem yet. When we do, you'll probably need to adopt a similar solution.

jimm, I think I recall you working on that tab drag-and-drop thumbnail stuff, but I can't find the bug... do you happen to recall what it is?
Flags: needinfo?(jmathies)

Comment 4

3 years ago
(In reply to Mike Conley (:mconley) - Needinfo me! from comment #3)
> (In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> > I'm not actively maintaining any of my addons, but TBH I'm kind of surprised
> > this doesn't work! The meat of the extension boils down to calling
> > ctx.drawWindow(window, ...) where ctx is a 2d Canvas context, and win is a
> > tabbrowser.contentWindow. I put the source up on GitHub since apparently I
> > didn't have it in VCS anywhere:
> > https://github.com/luser/tabpreview/blob/master/chrome/content/overlay.
> > js#L227
> > 
> > I just installed it and tried it locally, and the console shows:
> > TabPreview Error: Argument 1 of CanvasRenderingContext2D.drawWindow does not
> > implement interface Window.
> > 
> > so I guess contentWindow isn't really a Window?
> 
> In this case, no, it is not - contentWindow is a CPOW.
> 
> I do recall us having problems with tab drag-and-drop thumbnails (which use
> the same technique, I believe). I just tested, and they still appear to be
> disabled, so I suspect we haven't solved that problem yet. When we do,
> you'll probably need to adopt a similar solution.
> 
> jimm, I think I recall you working on that tab drag-and-drop thumbnail
> stuff, but I can't find the bug... do you happen to recall what it is?

You can use the async apis in PagerThumbs, should be easy to convert over:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/thumbnails/PageThumbs.jsm#195
Flags: needinfo?(jmathies)

Comment 5

3 years ago
Should I mark this as wontfix or leave it open?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Based on comment #2, I think this is WONTFIX.

Comment 7

3 years ago
(In reply to Jorge Villalobos [:jorgev] from comment #6)
> Based on comment #2, I think this is WONTFIX.

Just being polite.
With Firefox 57 only WebExtensions are permitted and are, by default, e10s compatible.
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.