1165729 - Check SetCapacity return value in nsSMILAnimationFunction::GetValues

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Biru Mohanathas [:poiru]]

Attachment: Check SetCapacity return value in nsSMILAnimationFunction::GetValues

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8606756 [details] [diff] [review]
Check SetCapacity return value in nsSMILAnimationFunction::GetValues

Looks like |result| (the thing we're calling SetCapacity on) is indeed a typedef for FallibleTArray, ever since bug 937614 landed and changed that typedef.

So yeah, we should be error-checking this SetCapacity call. Thanks for noticing this!

(Out of curiosity, how did you run across this? By auditing calls to SetCapacity & looking if they're on fallible vs. infallible arrays?)

Comment 3

[Biru Mohanathas [:poiru]]

(In reply to Daniel Holbert [:dholbert] from comment #2)
> (Out of curiosity, how did you run across this? By auditing calls to
> SetCapacity & looking if they're on fallible vs. infallible arrays?)

For bug 968520, I'm running a Clang AST matcher to automatically find and add `mozilla::fallible` to calls that use the fallible allocator. I noticed this while doing that.

(After bug 968520 lands, the compiler will emit a -Wunused-result warning for code like this!)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf12df7923f5

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf12df7923f5

Comment 6

[Biru Mohanathas [:poiru]]

Attachment: Use FallibleTArray::Clear instead of SetLength(0)

Comment 7

[Biru Mohanathas [:poiru]]

Attachment: Use FallibleTArray::TruncateLength instead of SetLength where possible

Comment 8

[Biru Mohanathas [:poiru]]

Attachment: Remove unnecessary template declaration for fallible nsTArray::AppendElement

Comment 9

[Biru Mohanathas [:poiru]]

Comment on attachment 8611381 [details] [diff] [review]
Use FallibleTArray::TruncateLength instead of SetLength where possible

Oops, wrong bug. Please ignore.

Comment 10

[Robert Longson [:longsonr]]

Comment on attachment 8611380 [details] [diff] [review]
Use FallibleTArray::Clear instead of SetLength(0)

This seems to be on the wrong bug too.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7061b445ad7

Comment 12

[Biru Mohanathas [:poiru]]

(In reply to Pulsebot from comment #11)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/e7061b445ad7

This had the wrong bug number (again...), but I won't bother relanding it since it's a trivial patch. Please ignore and sorry for the bugmail spam.

Comment 13

[Biru Mohanathas [:poiru]]

(In reply to Birunthan Mohanathas [:poiru] from comment #12)
> This had the wrong bug number (again...), but I won't bother relanding it
> since it's a trivial patch. Please ignore and sorry for the bugmail spam.

For future reference, the correct bug is bug 968520.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7061b445ad7