Closed
Bug 1165729
Opened 10 years ago
Closed 10 years ago
Check SetCapacity return value in nsSMILAnimationFunction::GetValues
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: poiru, Assigned: poiru)
References
Details
Attachments
(1 file, 3 obsolete files)
1.15 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8606756 -
Flags: review?(dholbert)
Comment 2•10 years ago
|
||
Comment on attachment 8606756 [details] [diff] [review]
Check SetCapacity return value in nsSMILAnimationFunction::GetValues
Looks like |result| (the thing we're calling SetCapacity on) is indeed a typedef for FallibleTArray, ever since bug 937614 landed and changed that typedef.
So yeah, we should be error-checking this SetCapacity call. Thanks for noticing this!
(Out of curiosity, how did you run across this? By auditing calls to SetCapacity & looking if they're on fallible vs. infallible arrays?)
Attachment #8606756 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #2)
> (Out of curiosity, how did you run across this? By auditing calls to
> SetCapacity & looking if they're on fallible vs. infallible arrays?)
For bug 968520, I'm running a Clang AST matcher to automatically find and add `mozilla::fallible` to calls that use the fallible allocator. I noticed this while doing that.
(After bug 968520 lands, the compiler will emit a -Wunused-result warning for code like this!)
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment hidden (offtopic) |
Comment hidden (offtopic) |
Comment hidden (offtopic) |
Assignee | ||
Updated•10 years ago
|
Attachment #8611384 -
Attachment is obsolete: true
Attachment #8611384 -
Flags: review?(nfroyd)
Comment hidden (offtopic) |
Comment hidden (offtopic) |
Comment 11•10 years ago
|
||
Assignee | ||
Comment 12•10 years ago
|
||
(In reply to Pulsebot from comment #11)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/e7061b445ad7
This had the wrong bug number (again...), but I won't bother relanding it since it's a trivial patch. Please ignore and sorry for the bugmail spam.
Assignee | ||
Comment 13•10 years ago
|
||
(In reply to Birunthan Mohanathas [:poiru] from comment #12)
> This had the wrong bug number (again...), but I won't bother relanding it
> since it's a trivial patch. Please ignore and sorry for the bugmail spam.
For future reference, the correct bug is bug 968520.
Comment 14•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•