Closed Bug 1165780 Opened 10 years ago Closed 9 years ago

Intermittent e10s browser_ManifestObtainer_obtain.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
e10s + ---
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: philor, Assigned: marcosc)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: btpp-active)

Attachments

(1 file)

Remove getting contentWindowAsCPOW
17.01 KB, patch
mconley
: review+
Details | Diff | Splinter Review
No description provided.
Summary: Intermittent browser_ManifestObtainer_obtain.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW → Intermittent e10s browser_ManifestObtainer_obtain.js | Uncaught exception - at :0 - Error: operation not possible on dead CPOW
Blocks: e10s-tests
tracking-e10s: --- → +
Assignee: nobody → mcaceres
Hmm... didn't know about this... having a looksy.
I rewrote the tests to no longer rely on getting contentWindowAsCPOW, which will hopefully stop the intermittent failures. I also simplified the tests. Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=135fd131dd39
Attachment #8758118 - Flags: review?(mconley)
Whiteboard: btpp-active
Comment on attachment 8758118 [details] [diff] [review] Remove getting contentWindowAsCPOW Review of attachment 8758118 [details] [diff] [review]: ----------------------------------------------------------------- Looks okay to me - and glad to get rid of the CPOW. ::: dom/manifest/test/browser_ManifestFinder_browserHasManifestLink.js @@ +14,2 @@ > run(result) { > + is(result, true, "Document has a web manifest."); Could also do: ok(result, "Document has a web manifest."); @@ +22,2 @@ > run(result) { > + is(result, false, "Document does not have a web manifest."); Similar to above, could do: ok(!result, "Document does not have a web manifest"); Et cetera. ::: dom/manifest/test/browser_ManifestObtainer_obtain.js @@ +101,2 @@ > > + //yield new Promise(()=>{}); Dead code ::: dom/manifest/test/resource.sjs @@ +67,4 @@ > ]); > > function handleRequest(request, response) { > + const queryMap = new URLSearchParams(request.queryString); I loooooooove URLSearchParams.
Attachment #8758118 - Flags: review?(mconley) → review+
Thanks Mike! Great feedback, as always! ❤️
Depends on: 1251175
The fix for this is included in: https://bugzilla.mozilla.org/show_bug.cgi?id=1251175
Fixed via bug 1251175
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
status-firefox41: affected → ---
status-firefox48: --- → fixed
status-firefox49: --- → fixed
status-firefox50: --- → fixed
Target Milestone: --- → mozilla50
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: