Closed
Bug 1165792
Opened 10 years ago
Closed 10 years ago
Check return value of FallibleTArray functions in MediaRawData.cpp
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: birunthan, Assigned: birunthan)
References
Details
Attachments
(1 file)
|
3.94 KB,
patch
|
jya
:
review+
|
Details | Diff | Splinter Review |
As discussed on IRC, unchecked FallibleTArray functions will cause warnings when bug 968520.
Attachment #8606842 -
Flags: review?(jyavenard)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8606842 [details] [diff] [review]
Wrap FallibleTArray functions with MOZ_ALWAYS_TRUE in MediaRawData.cpp
Review of attachment 8606842 [details] [diff] [review]:
-----------------------------------------------------------------
I thought I had put a comment explaining why it could never fail. But that is missing.
r=me with a one-line comment stating that those can't fail as EnsureSize() is always called first.
Attachment #8606842 -
Flags: review?(jyavenard) → review+
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•