1165844 - Add stopDhcp function to nsINetworkService

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Henry Chang [:hchang]]

Since Bug 1165776 will run dhcp_request library call in a separate thread, 'stopDhcp' becomes able to interrupt pending dhcp request. This bug is to add
'stopDhcp' function to nsINetworkService.

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug1165844.patch

Comment 2

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8606955 [details] [diff] [review]
Bug1165844.patch

Review of attachment 8606955 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you. 
Please open a bug to refactor wifinetutil.jsm

Comment 3

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=db5e7b53e254

Comment 4

[Henry Chang [:hchang]]

(In reply to Vincent Chang[:vchang] from comment #2)
> Comment on attachment 8606955 [details] [diff] [review]
> Bug1165844.patch
> 
> Review of attachment 8606955 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, thank you. 
> Please open a bug to refactor wifinetutil.jsm

Thanks for the review. I've already filed a bug to track the refactoring.
Thanks!

Comment 5

[Henry Chang [:hchang]]

Attachment: Bug1165844 v2 (r+'d)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/679cbdf6d143

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/679cbdf6d143