1165912 - Potential parallel accesses to ionLazyLinkList.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Prevent parallel mutations to HelperThread().ionLazyLinkList().

Comment 2

[Hannes Verschore [:h4writer]]

Comment on attachment 8607040 [details] [diff] [review]
Prevent parallel mutations to HelperThread().ionLazyLinkList().

Review of attachment 8607040 [details] [diff] [review]:
-----------------------------------------------------------------

Review comments on irc

Comment 3

[Nicolas B. Pierron [:nbp]]

(In reply to Hannes Verschore [:h4writer] from comment #2)
> Review comments on irc

summary: The list in which IonBuilder instances are stored in, is only manipulated on the main thread, even if it is stored as part of the helper thread state.  So, there is no need to lock the helper thread to append/remove elements from this list.  Instead of this patch, we can assert that ionLazyLinkList() is only used on the main thread, and that IonBuilder instances are in this list before being removed.

http://logs.glob.uno/?c=mozilla%23ionmonkey&s=19+May+2015&e=20+May+2015#c109408

Comment 4

[Nicolas B. Pierron [:nbp]]

Attachment: Ensure HelperThread().ionLazyLinkList() is only used from the main thread.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9708f0fcc1b0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9708f0fcc1b0