1165977 - FireFTP & Bugzilla: Submitting an attachment on bugzilla often fails with e10s enabled

Status: RESOLVED WORKSFORME

(Core :: General, defect, P2)

Description

[Tim Nguyen :ntim]

It sometimes works, but often fails.

STR :
- Try to submit an attachment to bugzilla

AR :
- Forms fails to submit, and you are not redirected to the bug page
- The attachment doesn't submit

Info :
Reproduced this on 2 machines already (Windows and Mac)

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Can you test in a clean profile? It sounds like an add-on issue. If it doesn't reproduce in a clean profile, it would be helpful if you could bisect your add-on list to find the one at fault.

(Note that safe mode also disables e10s, so safe mode won't be helpful here.)

Comment 2

[Tim Nguyen :ntim]

Attachment: Test

Comment 3

[Tim Nguyen :ntim]

So FireFTP seems to be the culprit here. Everytime I click on the submit button, I get logs from fireftpOverlay.js:119:0 (unsafe CPOW usage).

Also, I can only reproduce this with some attachments, not all of them.

Comment 4

[Mime Čuvalo]

Hi there,
I'm the developer of FireFTP.  What's the issue at hand with the overlay code?  Can someone narrow down for me what lines of code are causing troubles?  @tim what does "unsafe CPOW usage" mean?

Thanks!

Comment 5

[Tim Nguyen :ntim]

(In reply to Mime Čuvalo from comment #4)
> Hi there,
> I'm the developer of FireFTP.  What's the issue at hand with the overlay
> code?  Can someone narrow down for me what lines of code are causing
> troubles?  @tim what does "unsafe CPOW usage" mean?
> 
> Thanks!

Thank you for taking a look at this issue !

Information about CPOW : https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Cross_Process_Object_Wrappers

E10S experts will know better than me, but I think it's because you are using window.content at line 119 in src/content/js/etc/fireftpOverlay.js, which causes the cpow error in e10s.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

The "unsafe CPOW usage" message is only a warning. It may not be related to this bug. Someone would have to investigate and see.

Comment 7

[Tim Nguyen :ntim]

(In reply to Bill McCloskey (:billm) from comment #6)
> The "unsafe CPOW usage" message is only a warning. It may not be related to
> this bug. Someone would have to investigate and see.

The cpow warning showed each time I hit submit on bugzilla, and the logs were coming out of fireftpOverlay.js.

Comment 8

[Mime Čuvalo]

Someone will have to explain to me how this is related to FireFTP and how FireFTP is interfering with uploads.  It is unclear to me the intersection where the two programs are colliding.

Comment 9

[Tim Nguyen :ntim]

(In reply to Mime Čuvalo from comment #8)
> Someone will have to explain to me how this is related to FireFTP and how
> FireFTP is interfering with uploads.  It is unclear to me the intersection
> where the two programs are colliding.

I also found pretty weird that FireFTP was interfering with submitting a bugzilla attachment, but the toolbox showed logs from the FireFTP overlay each time submit attachment was clicked. I'll try to get a screencast when I can.

Comment 10

[Jerod Lycett]

Attachment: e10scan.txt

This is a test of the reported bug.

Comment 11

[Jerod Lycett]

I don't get any error messages, can you still replicate this?

Comment 12

[Tim Nguyen :ntim]

(In reply to Jerod Lycett from comment #11)
> I don't get any error messages, can you still replicate this?

I no longer can replicate this. But I can still see `unsafe CPOW usage` warnings from fireftpOverlay.js

Comment 13

[Mime Čuvalo]

Where does one find the CPOW usage warning? I'm looking at Browser Console in Nightly and not seeing anything as I browse around.

Comment 14

[Tim Nguyen :ntim]

(In reply to Mime Čuvalo from comment #13)
> Where does one find the CPOW usage warning? I'm looking at Browser Console
> in Nightly and not seeing anything as I browse around.
I don't have reliable steps to reproduce this warning, but if it helps, the warning precisely comes from here: https://github.com/mimecuvalo/fireftp/blob/master/src/content/js/etc/fireftpOverlay.js#L119. According to your code, this warning should show up each time the FireFTP overlay is being loaded.
The use of window.content is probably causing the warning in this case.

Comment 15

[:shell escalante]

addon update June 20 2016 - potential testing target to see if still occurring.

400K+ users

Comment 16

[:shell escalante]

not a guarantee - re-open if see again - but passed softvision testing to try to reproduce on latest versions.