Closed
Bug 1166116
Opened 10 years ago
Closed 10 years ago
Domain autocompletion improvements
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file)
There are still a couple of bugs with our domain autocompletion handling:
1) It's broken for multistage inputs (e.g., Japanese). These keyboards allow you to tap a combination of keys to enter a single character. When our autocompletion kicks in, it breaks any marked text in the input field.
2) Autocompleted text sometimes shows when it shouldn't. One example: Type "yak", then hit delete. We show an autocomplete suggestion for "yahoo.com", but we shouldn't since we just deleted a character.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8607287 -
Flags: review?(sarentz)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8607287 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/472
LGTM. Are you sure the delete behaviour that you describe is not what we do want?
Attachment #8607287 -
Flags: review?(sarentz) → review+
|
||
Updated•10 years ago
|
tracking-fennec: ? → +
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Stefan Arentz [:st3fan] from comment #2)
> Comment on attachment 8607287 [details] [review]
> Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/472
>
> LGTM. Are you sure the delete behaviour that you describe is not what we do
> want?
Yeah, we should only show completions after inserting a character, never after deleting them. This is how desktop and Android work.
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•