1166116 - Domain autocompletion improvements

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Brian Nicholson (:bnicholson)]

There are still a couple of bugs with our domain autocompletion handling:
1) It's broken for multistage inputs (e.g., Japanese). These keyboards allow you to tap a combination of keys to enter a single character. When our autocompletion kicks in, it breaks any marked text in the input field.
2) Autocompleted text sometimes shows when it shouldn't. One example: Type "yak", then hit delete. We show an autocomplete suggestion for "yahoo.com", but we shouldn't since we just deleted a character.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/472

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8607287 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/472

LGTM. Are you sure the delete behaviour that you describe is not what we do want?

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Stefan Arentz [:st3fan] from comment #2)
> Comment on attachment 8607287 [details] [review]
> Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/472
> 
> LGTM. Are you sure the delete behaviour that you describe is not what we do
> want?

Yeah, we should only show completions after inserting a character, never after deleting them. This is how desktop and Android work.