Closed Bug 1166134 Opened 10 years ago Closed 6 years ago

Downscale-during-decode uses more memory than it should in the B2G Gallery and Video apps

Categories

(Core :: Graphics: ImageLib, defect, P3)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: seth, Assigned: seth)

References

Details

(Keywords: feature, Whiteboard: [gfx-noted])

Downscale-during-decode is now enabled on B2G. Currently it uses more memory than it should in the B2G Gallery and Video apps. Why? There's a lot of layout code that hasn't been updated for downscale-during-decode, and that layout code causing us to decode images at their intrinsic size. We need to fix all of the code in layout that's doing this. This is a tracking bug for this work. It will depend on bugs that fix various instances of this problem, and it'll block bugs that are caused, at least in part, by this issue. I'm excluding bug 1151373 as a dependency for now, because it's a fairly large undertaking in its own right and I think we can avoid depending on it if we use <img> elements instead of CSS background images where feasible.
David, are there any other bugs this should block? It should probably block anything that has similar symptoms to the bugs that are already blocked: failures to decode images due to low memory.
Flags: needinfo?(dflanagan)
Seth: are you looking for gaia bugs about removing #-moz-samplesize? I've got bug 1121648 filed for that in the gallery app. And I think that bug 1168168 might be a symptom of the fact that I haven't done that yet. I'm not sure that the bugs you currently have in the blocks list are correct, because I think all of those bugs affect v2.2, and you're not turning on downscale-during-decode for 2.2, are you?
Flags: needinfo?(dflanagan) → needinfo?(seth)
No, removing #-moz-samplesize is really a separate issue. I'm mostly looking for bugs that involve excessive memory usage on *master*, where DDD is turned on. All of the blocked bugs, as far as I know, affect master as well as 2.2.
Flags: needinfo?(seth)
Milan, is this bug still relevant?
Flags: needinfo?(milan)
Whiteboard: [gfx-noted]
It is relevant, but it is meta and a feature.
Flags: needinfo?(milan)
Keywords: feature
Mass closing as we are no longer working on b2g/firefox os.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Mass closing as we are no longer working on b2g/firefox os.
You need to log in before you can comment on or make changes to this bug.