1166140 - gUM test framework tests MediaStream::CurrentTime == 0 before HTMLMediaElement::Play()

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

There is nothing keeping the MediaStream's currentTime from progressing before a media element plays it. It's likely just a typo - we should be testing HTMLMediaElement::CurrentTime.

Per the spec: http://www.w3.org/TR/2015/WD-mediacapture-streams-20150414/#media-element-attributes-when-playing-a-mediastream
> The initial value is 0 and the values increments linearly in real time whenever the stream is playing.

MediaStream also does not have a currentTime attribute in the current version of the spec: http://www.w3.org/TR/2015/WD-mediacapture-streams-20150414/#attributes

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: bz://1166140/pehrsons

/r/8985 - Bug 1166140 - Test media element currentTime before play() instead of stream's. r=drno

Pull down this commit:

hg pull -r 4119a508f89ed3e9c918eeb407c2d26c41aa00b0 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8607324 [details]
MozReview Request: bz://1166140/pehrsons

https://reviewboard.mozilla.org/r/8983/#review7677

Ship It!

Comment 3

[Nils Ohlmeier [:drno]]

FYI I think your try run is a little too much trimmed down. I don't really expect any real problems with this change, but I would prefer to see a try run across all platforms for a change like this.

Comment 4

[Andreas Pehrson [:pehrsons]]

(In reply to Nils Ohlmeier [:drno] from comment #3)
> FYI I think your try run is a little too much trimmed down. I don't really
> expect any real problems with this change, but I would prefer to see a try
> run across all platforms for a change like this.

Sure, I'll spin them up on all platforms. I'll see if I can get the tag syntax to work so I don't have to chase the M-chunk down across all platforms as well.

Comment 5

[Andreas Pehrson [:pehrsons]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=041f089728fd

Comment 6

[Andreas Pehrson [:pehrsons]]

(In reply to Andreas Pehrson [:pehrsons] (Telenor) from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=041f089728fd

That wasn't pretty. At least it tested what I wanted.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a65398893857

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a65398893857

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1166140 - Test media element currentTime before play() instead of stream's. r=drno