1166172 - Send MozContentEvent to gecko after the `system-first-paint` event is received.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] evanxd:bug-1166172 > mozilla-b2g:master

Comment 2

[Evan Tseng [:evanxd]]

The CI result: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=53fada9d870f094d9943183ff811930db71d1255

Comment 3

[Evan Tseng [:evanxd]]

Because of Bug 1167465, we need to do this work around[1] here.

[1]: https://github.com/mozilla-b2g/gaia/pull/30120

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8607382 [details] [review]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

Hi Alive and Dominic,

Because of Bug 1167465, we need to do this work around[1] here,
or the bug will block our works.

[1]: https://github.com/mozilla-b2g/gaia/pull/30120

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8607382 [details] [review]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

My only question is what if you missing the first-paint event because you are lazily loaded...?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8607382 [details] [review]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

r+ if this fixes the problem but would like to see followup to address the missing event.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #5)
> My only question is what if you missing the first-paint event because you
> are lazily loaded...?

This can't possibly right. We can't land a patch with this behavior.

Comment 8

[Dominic Kuo [:dkuo]]

Comment on attachment 8607382 [details] [review]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

Evan,

As we discussed offline, "system-first-paint" event looks a workable but probably not a suitable timing, I think there is a reason to explain why it works but the other events, let's investigate this together after you got back.

Comment 9

[Evan Tseng [:evanxd]]

Discussed with Alive and Dominic in person.We could try to use "Broadcast Channel API" to get the String list of System's audio channels. Let's try that!

Comment 10

[Evan Tseng [:evanxd]]

The documentations of Broadcast Channel API:

https://developer.mozilla.org/en-US/docs/Web/API/Broadcast_Channel_API

Comment 11

[Evan Tseng [:evanxd]]

Broadcast Channel API cannot work for this situation. Then I'll try Fabrice's suggestion[1].

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1165134#c9

Comment 12

[Evan Tseng [:evanxd]]

Comment on attachment 8607382 [details] [review]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/30606

Comment 13

[Evan Tseng [:evanxd]]

Comment on attachment 8607382 [details] [review]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/pull/30606

Comment 14

[Evan Tseng [:evanxd]]

Comment on attachment 8607382 [details] [review]
[gaia] evanxd:bug-1166172 > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/30606

Comment 15

[Evan Tseng [:evanxd]]

Attachment: Same patch, just with more comments.

Comment 16

[Evan Tseng [:evanxd]]

If the CI[1] for pr[2] is good, just land the code.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=03ec48f6bae180c567577cd6a79b22c2adc002be
[2]: https://github.com/mozilla-b2g/gaia/pull/30606

Comment 17

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/668361bff1694487b33580db1377a1df115d82ee