1166174 - [B2G] GetCellInfoList cannot work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Alphan Chen [:alchen]]

When using "GetCellInfoList" in gecko, the callback does not being called.

Comment 1

[Jessica Jong [:jessica] (inactive)]

Hi Alphan, I remember testing it locally... may I know how you are using it? or do you have a patch so that I can test it? Thanks.

Comment 2

[Edgar Chen [:edgar]]

It is a regression of bug 1113054, the response handler of REQUEST_GET_CELL_INFO_LIST is overwritten to |null| [1]. :(

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1113054

Comment 3

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #2)
> It is a regression of bug 1113054, the response handler of
> REQUEST_GET_CELL_INFO_LIST is overwritten to |null| [1]. :(
> 
> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1113054
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
https://hg.mozilla.org/mozilla-central/annotate/e94dc650c901/dom/system/gonk/ril_worker.js#l5647

Comment 4

[Jessica Jong [:jessica] (inactive)]

(In reply to Edgar Chen [:edgar][:echen] from comment #3)
> (In reply to Edgar Chen [:edgar][:echen] from comment #2)
> > It is a regression of bug 1113054, the response handler of
> > REQUEST_GET_CELL_INFO_LIST is overwritten to |null| [1]. :(
> > 
> > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1113054
>       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> https://hg.mozilla.org/mozilla-central/annotate/e94dc650c901/dom/system/gonk/
> ril_worker.js#l5647

Oh I see, thanks for the update. :)

Comment 5

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Fix and add marionette test for it.

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8610494 [details] [diff] [review]
Patch, v1

Review of attachment 8610494 [details] [diff] [review]:
-----------------------------------------------------------------

In this patch, I add a test for getCellInfoList().
But RIL_REQUEST_GET_CELL_INFO_LIST is introduced since ril version 8 [1], emulator-ics (ril version 7) doesn't support it. We have to skip it when in emualtor-ics.
I have tried adding `skip-if = android_version == "15"` in manifest, but it doesn't work. :(
I guess marionette test doesn't support `android_version` and we probably need to do the same thing as in mochitest [2] and xpcshell [3] to make it work? (I am not sure).
Before figuring out how to make marionette test support `android_version`, I just check `ro.build.version.sdk` system property in test script.

Hi Hsinyi, would you mind reviewing this? Thank you.

[1] https://github.com/mozilla-b2g/platform_hardware_ril/commit/8a9e02161271505de274db0c3a88087056dd5dfc
[2] https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#503
[3] https://dxr.mozilla.org/mozilla-central/source/testing/xpcshell/remotexpcshelltests.py#218

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8610494 [details] [diff] [review]
Patch, v1

Review of attachment 8610494 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!!!

Comment 8

[Edgar Chen [:edgar]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=13fed2ef055c&exclusion_profile=false

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/fc7990f05afa

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fc7990f05afa