Add an (empty) "taskcluster" build pool

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments, 2 obsolete attachments)

Comment hidden (empty)
The options for build pools are currently "staging" and "production":
  https://github.com/mozilla/build-mozharness/blob/master/configs/builds/build_pool_specifics.py

Taskcluster is basically a new pool.  Let's add a new clause to that file omitting information that's not useful from taskcluster.
Assignee: nobody → dustin
Summary: Add an (empty) ' → Add an (empty) "taskcluster" build pool
Created attachment 8607679 [details]
MozReview Request: bz://1166380/dustin

/r/9065 - Bug 1166380: add 'taskcluster' build pool; r=mshal

Pull down this commit:

hg pull -r 6e253a21f3ccc722d668487b5334c0d213ec0e01 https://reviewboard-hg.mozilla.org/build-mozharness
Attachment #8607679 - Flags: review?(mshal)
Comment on attachment 8607679 [details]
MozReview Request: bz://1166380/dustin

https://reviewboard.mozilla.org/r/9063/#review7697

Ship It!
Attachment #8607679 - Flags: review?(mshal) → review+
Actually, does 'taskcluster' need to be added to buildbase.py:BuildOptionParser where it sets build_pools? Not sure if you need that for your use-case.
Good point - I'll re-draft.
Attachment #8607679 - Flags: review+
Duplicate of this bug: 1164914
Comment on attachment 8607679 [details]
MozReview Request: bz://1166380/dustin

/r/9065 - Bug 1166380: add 'taskcluster' build pool; r=mshal
/r/9137 - Bug 1166380: don't hard-code build pool names in buildbase.py

Pull down these commits:

hg pull -r d84645ed8805550daaaef9f40d509f1af0e6b287 https://reviewboard-hg.mozilla.org/build-mozharness
Attachment #8607679 - Flags: review?(mshal)
Comment on attachment 8607679 [details]
MozReview Request: bz://1166380/dustin

https://reviewboard.mozilla.org/r/9063/#review7835

Ship It!
Attachment #8607679 - Flags: review?(mshal) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
:mshal noted that there are two places that still reference build_pool.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8607679 [details]
MozReview Request: bz://1166380/dustin

/r/9065 - Bug 1166380: fix remaining build_pools occurrences; r=mshal

Pull down this commit:

hg pull -r b3f509ec95ee0a1340f458f340686d8428592b6f https://reviewboard-hg.mozilla.org/build-mozharness
Attachment #8607679 - Flags: review+ → review?(mshal)
Comment on attachment 8607679 [details]
MozReview Request: bz://1166380/dustin

https://reviewboard.mozilla.org/r/9063/#review7853

Looks good, hopefully try is happy...
Attachment #8607679 - Flags: review?(mshal) → review+
After several failures to specify the mozharness repo correctly, yes, try is reasonably happy (linux and android so far)
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb451f69d5b7

remote:   https://hg.mozilla.org/build/mozharness/rev/0e6e9348c2ed
..and grafted to production..
remote:   https://hg.mozilla.org/build/mozharness/rev/2ae240c4f588
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
There are places in buildbase that assume there's a symbol_server_host (and probably other keys).

Traceback (most recent call last):                                                                                      
  File "./mozharness/scripts/fx_desktop_build.py", line 166, in <module>                                                
    fx_desktop_build = FxDesktopBuild()                                                                                 
  File "./mozharness/scripts/fx_desktop_build.py", line 98, in __init__                                                 
    super(FxDesktopBuild, self).__init__(**buildscript_kwargs)                                                          
  File "/home/worker/mozharness/mozharness/mozilla/building/buildbase.py", line 543, in __init__                        
    self.query_build_env()                                                                                              
  File "/home/worker/mozharness/mozharness/mozilla/building/buildbase.py", line 785, in query_build_env                 
    replace_dict.update({"symbol_server_host": c['symbol_server_host']})                                                
KeyError: 'symbol_server_host'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 8610753 [details] [diff] [review]
dont-fail.patch

I'll test this in try at the same time.
Attachment #8610753 - Flags: review?(mshal)
Comment on attachment 8610753 [details] [diff] [review]
dont-fail.patch

Never mind, that very much did not work.  I'll just add the values to build_pool_specifics.py
Attachment #8610753 - Flags: review?(mshal)
Created attachment 8610825 [details] [diff] [review]
symbol-and-stage-for-tc.patch

This has worked in try
Attachment #8610753 - Attachment is obsolete: true
Attachment #8610825 - Flags: review?(mshal)

Updated

3 years ago
Attachment #8610825 - Flags: review?(mshal) → review+
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Comment on attachment 8607679 [details]
MozReview Request: bz://1166380/dustin
Attachment #8607679 - Attachment is obsolete: true
Attachment #8620333 - Flags: review+
Attachment #8620334 - Flags: review+
Created attachment 8620333 [details]
MozReview Request: Bug 1166380: fix remaining build_pools occurrences; r=mshal
Created attachment 8620334 [details]
MozReview Request: Bug 1166380: don't hard-code build pool names in buildbase.py
You need to log in before you can comment on or make changes to this bug.