1166453 - "Image Search Options" add-on does not work with e10s

Status: RESOLVED WORKSFORME

(Firefox :: Extension Compatibility, defect)

Description

[AsukaLangleyfag]

https://addons.mozilla.org/en-US/firefox/addon/image-search-options/
I already contacted with author ([e-mail]) and he said:
>If there's no easy workaround it may be a while before I can can do a
proper fix. Very troubling...

Comment 1

[Andreas Jung]

Attachment: imagesearchoptions.patch

With the changes in the attached patch image search options works in the current firefox developer edition with e10s enabled.

Comment 2

[Andreas Jung]

Attachment: imagesearchoptions2.patch

Same as v1 but avoids an unnecessary double conversion and therefore works on large images properly as well.

Also, I forgot to mention the {relatedToCurrent: true} change is not strictly necessary, but it makes the extension behave like open link in new tab and similar menu items which is the correct thing to do.

Comment 3

[Albert]

Nice job Andreas! Have you contacted the original developer yet?

Comment 4

[xamayon]

Thanks Andreas! Just applied the patch and submitted for review a few minutes ago. Hopefully all goes well and it gets released soon.

Comment 5

[Dave Miller [:justdave]]

I have the Image Search Options addon installed from AMO that claims it was released on 2016/03/04, does that mean I have this fix now?  arewee10syet.com says it's still not compatible, but points at this bug.  Does the bug need to be resolved?  (I can't test because I have e10s disabled because of too many addons still marked incompatible)

Comment 6

[AsukaLangleyfag]

(In reply to Dave Miller [:justdave] ([e-mail]) from comment #5)
> I have the Image Search Options addon installed from AMO that claims it was
> released on 2016/03/04, does that mean I have this fix now? 
> arewee10syet.com says it's still not compatible, but points at this bug. 
> Does the bug need to be resolved?  (I can't test because I have e10s
> disabled because of too many addons still marked incompatible)

Author fixed it, now it works with e10s, can confirm.