1166601 - Give remote-troubleshooting permissions to self-repair.mozilla.org

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Motivation:  Heartbeat surveys need explanatory covariates to explain user scores.  The Remote-troubleshooting permission give a small, constrained set to variables to analyze.

Claims:
- these variables are low risk for identity compromise
- these variables allow some useful analysis
- this api is sufficient 

(Work on consuming this at the server is:  https://github.com/mozilla/self-repair-server/issues/117)

Comment 1

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

(See:  https://bugzilla.mozilla.org/show_bug.cgi?id=1079563)

Comment 2

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Attachment: Give remote-troubleshooting permissions to self-repair.mozilla.org

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8607928 [details] [diff] [review]
Give remote-troubleshooting permissions to self-repair.mozilla.org

Review of attachment 8607928 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/permissions
@@ +18,5 @@
>  
>  # Remote troubleshooting
>  host	remote-troubleshooting	1	input.mozilla.org
>  host	remote-troubleshooting	1	support.mozilla.org
> +host  remote-troubleshooting  1 self-repair.mozilla.org

Nit: indentation is off but otherwise this is all that's needed from the code side IIRC.

Comment 4

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Attachment: v2 Give remote-troubleshooting permissions to self-repair.mozilla.org

Comment 5

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Comment on attachment 8608170 [details] [diff] [review]
v2  Give remote-troubleshooting permissions to self-repair.mozilla.org

Review of attachment 8608170 [details] [diff] [review]:
-----------------------------------------------------------------

(I have no idea if this needs tests, or what to do in that case)

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8608170 [details] [diff] [review]
v2  Give remote-troubleshooting permissions to self-repair.mozilla.org

Review of attachment 8608170 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the technical side. I don't see any test that needs updating for this.

r?bsmedberg on the privacy aspect.

Comment 7

[Benjamin Smedberg]

I don't want to approve this particular bug without seeing the broader engineering/UX plan. In particular, would the UI change, and is the data collection here already controlled by the FHR checkbox in prefs?

Comment 8

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

reopening this, cc-ing rweiss, Osmose.  

Deciding exactly what data the SHIELD service needs to see needs designing.  

Claim:  remote troubleshooting's set is a good first step.

Comment 9

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Closing, because I think the self-repair system addon will not need this.

Comment 10

[Osmose [:osmose, :mkelly]]

Correct, it will not.