add build configuration for Chirimen to main B2G repository

NEW
Unassigned

Status

Firefox OS
General
3 years ago
2 years ago

People

(Reporter: dietrich, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Reporter)

Updated

3 years ago
Blocks: 1166579
(Reporter)

Comment 1

3 years ago
Chirimen build config is in https://github.com/MozOpenHard/B2G.

We should add it to the main B2G repo as a device option.
Created attachment 8705455 [details] [review]
WIP Patch : Manifest

Manifest change to add chirimen to master.  Patch for config.sh incoming.

Comment 3

2 years ago
WOW, thanks Hirata-san !
Created attachment 8705457 [details] [review]
WIP Patch : Chirimen on master

WIP Patch : config.sh 

Note, the manifest has to pushed in order for the config.sh to work.  Otherwise you need to change the (default) location for the manifest in the patch.

Comment 5

2 years ago
Hirata-san,

Unfortunately, current CHIRIMEN is supporting only v2.1( gaia / gecko ).
Then, it seems to me that we would have to change revision to v2.1.
https://github.com/nhirata/b2g-manifest/blob/bug_1166608_add_chirimen/chirimen.xml#L18-L26 

# we are working to migrate v2.5, but it just WIP :(
Hrm, ok.  I guess I should move the project over to the main repository first with v2.1 support then add the master version the port over.  I was hoping just to do a straight port to master.
If we are to move MOZOPENHARD/device-chirimen to mozilla-b2g/device-chirimen, we would need help from someone who has the access to add to that repo and also need to adjust the manifest.  For now, I just have PRs to push to the v2.1 as a manifest and edit the B2G repo.  Note, you will need to type BRANCH=v2.1 ./config.sh chirimen in order to compile for the device if these are pushed to the main repo.

Adding the b2g-manifest to v2.1 as a PR : 
https://github.com/mozilla-b2g/b2g-manifest/pull/432

Adding B2G to the main repo as a PR :
https://github.com/mozilla-b2g/B2G/pull/505
Created attachment 8721082 [details] [review]
Manifest for v2.1 patch

Hal, since mozharness doesn't have v2.1.py any more the test fails.  is there any way that we can ignore v2.1 for buildbot / b2g_bumper?
Attachment #8705455 - Attachment is obsolete: true
Created attachment 8721084 [details] [review]
B2G changes to add chirimen for config and flashing.
Attachment #8705457 - Attachment is obsolete: true
Yamamoto-san, I think we need to push device-chirimen to mozilla-b2g/chirimen and edit the manifest to reflect this change in order to make this complete.  Having said that, here's most of the push into the main repository.

Also I asked Hal to see about the test failure for the b2g-manifest. 

I think we would really need to get the chirimen to work on master after the sunsetting portion happens.
Flags: needinfo?(yu-yamamoto)

Comment 11

2 years ago
Hirata-san, I got it.

> I think we would really need to get the chirimen to work on master after the sunsetting portion happens.
We, as a Japan community, will cooperate that as much as we can. 
If you would like to get CHIRIMEN to confirm to built it, to test in US, you might be able to consult to get it. 
Asai-san, and Akatsuka-san will help it, you can NI or mail for them.
# they are in this bug at CC.
Flags: needinfo?(yu-yamamoto)
Yamamoto-san, thanks.  I do have a CHIRIMEN board, I emailed Asai-san and Akatsuka-san in regards to getting it working on master after the sunset of the project.
Flags: needinfo?(hwine)
Thanks for the ni -- I don't read bug mail.

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #8)
> Hal, since mozharness doesn't have v2.1.py any more the test fails.  is
> there any way that we can ignore v2.1 for buildbot / b2g_bumper?

Sorry - I don't know this part of the code at all. That said, it looks like you could modify the b2g-manifest run_travis_tests.sh file on the branch you care about to skip the tests.

The v2.1.py file being absent from the mozharness repo is what keeps b2g_bumper from running in production for the branch. But the test is still being run, which is leading to the failure. Just delete the b2g_bumper test, and I think you'll be good.
Flags: needinfo?(hwine)
Those bits of info + https://bugzilla.mozilla.org/show_bug.cgi?id=1153802 info helped out a lot.
New PR made.
Not sure who the best person to review the patches is... Will try to talk to someone about it soon.
Fabrice, would it be ok for them to add this to the 2.1 portion of b2g?  The plan as far as I am aware is to have 2.1, 2.5 be a part of chirimen and after the transition plan have chirimen on master.
Flags: needinfo?(fabrice)
Flags: needinfo?(fabrice)
You need to log in before you can comment on or make changes to this bug.