1166636 - In-line paired devices appear in both 'Paired devices' and 'Devices in the area' sections of Settings app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Ben Tian (inactive)]

Pre-condition:
  Setting app has already launched and exists in background.

STR:
  1) Open gallery app, share -> Bluetooth
  2) Pair with one discovered device, and accept pairing request.
  3) Switch to Settings app -> Bluetooth panel

Expected Result:
  The paired device appears in "Paired devices" section only

Actual Result:
  The paired device appears in both "Paired devices" and "Device in the area" sections

Reproduction rate: 100%

Comment 1

[Ben Tian (inactive)]

Ian, please help on this bug per offline discussion and investigation.

Comment 2

[Ben Tian (inactive)]

Nominate for 2.2?

Comment 3

[Eric Chang [:ericcc] [:echang]]

in‑moztrap? for inline pairing case

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] ian-liu:bluetooth/bug1166636_remove_paired_device_from_found_device_list_while_inline_pairing_via_bluetooth_app > mozilla-b2g:master

Comment 5

[[e-mail], [e-mail]]

Comment on attachment 8609219 [details] [review]
[gaia] ian-liu:bluetooth/bug1166636_remove_paired_device_from_found_device_list_while_inline_pairing_via_bluetooth_app > mozilla-b2g:master

The root cause is that Settings/Bluetooth apps only remove device paired from found device list if the device is paired by apps-self. 

In order to check the pairing action which is triggered by app-self, there is already existed 'pairingAddress' flag for identification. To considerate side effect and APIv1/v2 migration, I give a patch to fix the problem with minimise modification.

Arthur, could you please help to review my pr? Thanks.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8609219 [details] [review]
[gaia] ian-liu:bluetooth/bug1166636_remove_paired_device_from_found_device_list_while_inline_pairing_via_bluetooth_app > mozilla-b2g:master

The patch is sane and the impact seems minimal. r=me, thanks!

Comment 7

[[e-mail], [e-mail]]

Thanks for Arthur's reviewing effort. Since the patch is landed, we can close the issue.

Gaia/master: https://github.com/mozilla-b2g/gaia/commit/348f579664428ed95e949d8d4baf13b7a0ba13d8

Comment 8

[[e-mail], [e-mail]]

Comment on attachment 8609219 [details] [review]
[gaia] ian-liu:bluetooth/bug1166636_remove_paired_device_from_found_device_list_while_inline_pairing_via_bluetooth_app > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): uncompleted UI updating flow for Bluetooth inline pairing
[User impact] if declined: per STR, the device paired is still in found device list
[Testing completed]: manual test, and no test broken on try-server
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 9

[Josh Cheng [:josh]]

Norry,
please verify on master. Thanks

Comment 10

[Verson Xiong (Leave from Mozilla)]

This bug has been verified as fail on latest build of Flame v3.0,Nexus5 v3.0,by the STR in Comment 0 
Actually Result：The paired device appears in both "Paired devices" and "Device in the area" sections.
Reproduce rate:5/5
See attachment:Verify_master.mp4 &logcat_1831.txt
Device:Flame v3.0 build(Fail)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150525.192755
Firmware Date          Mon May 25 19:28:07 EDT 2015
Bootloader             L1TC000118D0

Device:Nexus 5 v3.0 build(Fail)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150525.192207
Firmware Date          Mon May 25 19:22:24 EDT 2015
Bootloader             HHZ12f

Comment 11

[Verson Xiong (Leave from Mozilla)]

Attachment: Verify_master.mp4

Comment 12

[Verson Xiong (Leave from Mozilla)]

Attachment: logcat_1831.txt

Comment 13

[Josh Cheng [:josh]]

Hi Verson, Please NI me if patch verify fail.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this patch when you get a chance.

Comment 15

[[e-mail], [e-mail]]

Hi Ryan,

I have requested Gaia v2.2 approval for this patch. Please kindly re-check on the attachment field. Thanks.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Release Management handles approvals, not me.

Comment 17

[Verson Xiong (Leave from Mozilla)]

Attachment: verrify_3.0.mp4

This bug has been verified as pass on latest build of Flame v3.0,Nexus5 v3.0,by the STR in Comment 0 
Actually Result:The paired device appears in "Paired devices" section only
Reproduce rate:0/5
See attachment:Verify_3.0.mp4

Device:Flame v3.0 build(pass)
Build ID               20150526160204
Gaia Revision          8ca93673869a64e09ed6153c5402896822dfb253
Gaia Date              2015-05-26 19:31:37
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1e4e369822ac
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150526.195035
Firmware Date          Tue May 26 19:50:45 EDT 2015
Bootloader             L1TC000118D0

Device:Nexus 5 v3.0 build(pass)
Build ID               20150526160204
Gaia Revision          8ca93673869a64e09ed6153c5402896822dfb253
Gaia Date              2015-05-26 19:31:37
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1e4e369822ac
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150526.195039
Firmware Date          Tue May 26 19:50:56 EDT 2015
Bootloader             HHZ11k

Comment 18

[Josh Cheng [:josh]]

Comment on attachment 8609219 [details] [review]
[gaia] ian-liu:bluetooth/bug1166636_remove_paired_device_from_found_device_list_while_inline_pairing_via_bluetooth_app > mozilla-b2g:master

Hi Norry,

Please verify on 2.2 after you confirm patch is landed there.
Thanks!

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/221f806fdf9799fbcd664f8dab7184e5b009c055

Comment 20

[Verson Xiong (Leave from Mozilla)]

Attachment: Verify_2.2.mp4

This bug has been verified as pass on latest build of Flame v2.2, Nexus5 v2.2, by the STR in Comment 0 
Actually Result:The paired device appears in "Paired devices" section only
Reproduce rate:0/8
See attachment:Verify_2.2.mp4

Device:Flame v2.2 build(pass)
Build ID               20150527162504
Gaia Revision          0f162853ae6a3e2b05164878e49276ead0d6f09c
Gaia Date              2015-05-27 22:50:51
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f2efe1d20e12
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150527.195632
Firmware Date          Wed May 27 19:56:46 EDT 2015
Bootloader             L1TC000118D0

Device:Nexus 5 v2.2 build(pass)
Build ID               20150527162504
Gaia Revision          0f162853ae6a3e2b05164878e49276ead0d6f09c
Gaia Date              2015-05-27 22:50:51
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f2efe1d20e12
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150527.195418
Firmware Date          Wed May 27 19:54:38 EDT 2015
Bootloader             HHZ11k

Comment 21

[Teri Wen [:twen]]

Added in Bluetooth suite https://moztrap.mozilla.org/manage/case/16268/