Closed Bug 1166706 Opened 4 years ago Closed 4 years ago

Clicking the empty space of Pocket's confirmation panel results in an error thrown by CustomizableUI.jsm:1536:10

Categories

(Firefox :: Pocket, defect, P5)

38 Branch
defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 41
Iteration:
41.2 - Jun 8
Tracking Status
firefox38.0.5 --- affected
firefox41 --- fixed

People

(Reporter: avaida, Assigned: Gijs)

References

Details

Attachments

(1 file, 1 obsolete file)

Reproducible on:
Beta 38.0.5b3-build1 (20150518141916)

Affected platforms:
Window 7 (x64), Mac OS X 10.9.5, Ubuntu 14.04 (x64)

Preconditions:
* user is logged into Pocket

Steps to reproduce:
1. Open a random page, e.g. https://www.mozilla.org/en-US/mission/
2. Click the Pocket toolbar button.
3. Click anywhere on the empty space available in the confirmation panel displayed by Pocket.

Expected result:
There are no errors thrown for this action.

Actual result:
Clicking the empty space from the confirmation panel results in CustomizableUI.jsm:1536:10 throwing the following error in the Browser Console:
> TypeError: target.getAttribute is not a function
I get this too, error is in the conditional in _isOnInteractiveElement():

      ...
      // Break out of the loop immediately for disabled items, as we need to
      // keep the menu open in that case.
      if (target.getAttribute("disabled") == "true") {
        return true;
      }
      ...

Gijs, is this concerning or not? (I sorta suspect this may be unique to the panel contents being an iframe, event.target can be weird in such cases.)
Flags: needinfo?(gijskruitbosch+bugs)
Priority: -- → P5
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 41.2 - Jun 8
Points: --- → 2
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Attached file MozReview Request: bz://1166706/Gijs (obsolete) —
/r/9357 - Bug 1166706 - deal with iframes in panels, r?dolske

Pull down this commit:

hg pull -r 944a68ba1fb020f80da2914cb6108a4813a89a76 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8610673 - Flags: review?(dolske)
Comment on attachment 8610673 [details]
MozReview Request: bz://1166706/Gijs

/r/9357 - Bug 1166706 - deal with iframes in panels, r?dolske

Pull down this commit:

hg pull -r 944a68ba1fb020f80da2914cb6108a4813a89a76 https://reviewboard-hg.mozilla.org/gecko/
Comment on attachment 8610673 [details]
MozReview Request: bz://1166706/Gijs

https://reviewboard.mozilla.org/r/9355/#review8095

::: browser/components/customizableui/CustomizableUI.jsm:1514
(Diff revision 1)
> +          break;

Shouldn't this just always bail when we hit a DOCUMENT_NODE?

Perhaps I'm not being creative, but I'm having a hard time imagining cases where someone would put an <iframe> in the other things we're checking for in this function?
Attachment #8610673 - Flags: review?(dolske)
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8610673 [details]
MozReview Request: bz://1166706/Gijs

(In reply to Justin Dolske [:Dolske] from comment #4)
> Comment on attachment 8610673 [details]
> MozReview Request: bz://1166706/Gijs
> 
> https://reviewboard.mozilla.org/r/9355/#review8095
> 
> ::: browser/components/customizableui/CustomizableUI.jsm:1514
> (Diff revision 1)
> > +          break;
> 
> Shouldn't this just always bail when we hit a DOCUMENT_NODE?
> 
> Perhaps I'm not being creative, but I'm having a hard time imagining cases
> where someone would put an <iframe> in the other things we're checking for
> in this function?

While I agree with the sentiment, the SDK does exactly this (iframes in toolbarbuttons for "widget").
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8610673 - Flags: review?(dolske)
Comment on attachment 8610673 [details]
MozReview Request: bz://1166706/Gijs

*sigh* I can't tell how to, y'know, actually have ReviewBoard mark this as r+.
Attachment #8610673 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/d975c1a22c75
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Attachment #8610673 - Attachment is obsolete: true
Attachment #8620336 - Flags: review+
You need to log in before you can comment on or make changes to this bug.