Closed Bug 1166781 Opened 11 years ago Closed 10 years ago

Search results aren't updated when deleting characters

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
ARM
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: aaronmt, Assigned: wesj)

References

Details

Attachments

(1 file, 1 obsolete file)

PR https://github.com/mozilla/firefox-ios/pull/799
47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
Currently we retain search results on empty field.
Which means we should have an empty placeholder? Or do we cancel out?
Is this a regression? We should flip to Top Sites if this is empty.
tracking-fennec: ? → +
To expand a bit more, it looks like we aren't updating results in general any time we hit the backspace/delete key.
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
tracking-fxios: --- → +
Summary: Clear search results on empty field → Search results aren't updated when deleting characters
Assignee: bnicholson → jhugman
Is this still happening in the nightly build? I don't think it is. Aaron can you confirm?
tracking-fennec: + → ---
Flags: needinfo?(aaron.train)
Yes.
Flags: needinfo?(aaron.train)
Attachment #8632927 - Flags: review?(sarentz)
Attachment #8632927 - Flags: review?(rnewman)
Comment on attachment 8632927 [details] [review] override func deleteBackward() in AutoCompleteTextField Looks good to me. Removing rnewman. Please land.
Attachment #8632927 - Flags: review?(sarentz)
Attachment #8632927 - Flags: review?(rnewman)
Attachment #8632927 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Backed out due to regressions. STR: 1. Enter "yah" that should autocomplete for "yahoo.com" 2. Hit backspace twice "yahoo.com" then gets suggested again. That is, it takes two deletions every time i want to go back a character: one to clear the suggestion, another to actually do the deletion. Note that we want our autocompetion logic to mirror desktop, where show autocomplete suggestions only when entering new characters -- never when deleting them. Friendly reminder to try running tests -- this PR causes DomainAutocompleteTests to fail. https://github.com/mozilla/firefox-ios/commit/8c64b395da039a319fa7008d90c125fbf502b2a1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: jhugman → nobody
Attachment #8638349 - Flags: review?(bnicholson)
Assignee: nobody → wjohnston
Comment on attachment 8638349 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/799 LGTM -- some suggestions for tests in the PR. At minimum, please make sure SearchTests.swift is passing.
Attachment #8638349 - Flags: review?(bnicholson) → review+
I have found bug which is regression of this issue. https://bugzilla.mozilla.org/show_bug.cgi?id=1187686
I have found another bug which is regression of this issue. https://bugzilla.mozilla.org/show_bug.cgi?id=1187688
Depends on: 1187686
Depends on: 1187688
Let's get a handle on this
https://github.com/mozilla/firefox-ios/commit/e22d8bce00dc352b8dd784f6190b4ad9f40c3130 Should consider backing out again due to regressions, but let's see where we stand with the proposed fixes. Thanks, codester!
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Attachment #8632927 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: