[Communications] Convert string.contains to string.includes

RESOLVED FIXED in 2.2 S13 (29may)

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

unspecified
2.2 S13 (29may)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

Assignee

Description

4 years ago
Seeing errors like: 

JavaScript warning: app://communications.gaiamobile.org/contacts/test/unit/views/list_test.js?time=1432147277003, line 811: String.prototype.contains() is deprecated and will be removed in a future release; use String.prototype.includes() instead
Assignee

Updated

4 years ago
Component: Gaia::System → Gaia::Contacts
Assignee

Comment 2

4 years ago
Comment on attachment 8608270 [details] [review]
[gaia] KevinGrandon:bug_1166859_communications_string_includes > mozilla-b2g:master

Francisco or Etienne - Either of you guys have a minute to review this? Thanks!
Attachment #8608270 - Flags: review?(francisco)
Attachment #8608270 - Flags: review?(etienne)
Comment on attachment 8608270 [details] [review]
[gaia] KevinGrandon:bug_1166859_communications_string_includes > mozilla-b2g:master

stamping the dialer part but we still need Francisco for the contacts part.
Attachment #8608270 - Flags: review?(etienne) → review+
Comment on attachment 8608270 [details] [review]
[gaia] KevinGrandon:bug_1166859_communications_string_includes > mozilla-b2g:master

Thanks Kevin!
Attachment #8608270 - Flags: review?(francisco) → review+
http://docs.taskcluster.net/tools/task-graph-inspector/#9LNMRLAPQ_agSrgM3F3Xcg

The pull request failed to pass integration tests. It could not be landed, please try again.
Assignee

Comment 6

4 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/54d1324b487f0433cd6b8ce49dc0c7b14ed41155
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S13 (29may)
You need to log in before you can comment on or make changes to this bug.