Closed
Bug 1166859
Opened 9 years ago
Closed 9 years ago
[Communications] Convert string.contains to string.includes
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S13 (29may)
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Seeing errors like: JavaScript warning: app://communications.gaiamobile.org/contacts/test/unit/views/list_test.js?time=1432147277003, line 811: String.prototype.contains() is deprecated and will be removed in a future release; use String.prototype.includes() instead
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Component: Gaia::System → Gaia::Contacts
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8608270 [details] [review] [gaia] KevinGrandon:bug_1166859_communications_string_includes > mozilla-b2g:master Francisco or Etienne - Either of you guys have a minute to review this? Thanks!
Attachment #8608270 -
Flags: review?(francisco)
Attachment #8608270 -
Flags: review?(etienne)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8608270 [details] [review] [gaia] KevinGrandon:bug_1166859_communications_string_includes > mozilla-b2g:master stamping the dialer part but we still need Francisco for the contacts part.
Attachment #8608270 -
Flags: review?(etienne) → review+
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8608270 [details] [review] [gaia] KevinGrandon:bug_1166859_communications_string_includes > mozilla-b2g:master Thanks Kevin!
Attachment #8608270 -
Flags: review?(francisco) → review+
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•9 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#9LNMRLAPQ_agSrgM3F3Xcg The pull request failed to pass integration tests. It could not be landed, please try again.
|
|
Assignee | |
Comment 6•9 years ago
|
||
In master: https://github.com/mozilla-b2g/gaia/commit/54d1324b487f0433cd6b8ce49dc0c7b14ed41155
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S13 (29may)
You need to log in
before you can comment on or make changes to this bug.
Description
•