1166880 - (SQLite3.8.10.2) Upgrade to SQLite 3.8.10.2

Status: RESOLVED WONTFIX

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[NVD]

https://www.sqlite.org/news.html

"Yikes! Index corruption after a sequence of valid SQL statements!

It has been many years since anything like this bug has snuck into an official SQLite release. But for the pasts seven months (version 3.8.7 through version 3.8.10.1) if you do an INSERT into a carefully crafted schema in which there are two nested triggers that convert an index key value from TEXT to INTEGER and then back to TEXT again, the INTEGER value might get inserted as the index key instead of the correct TEXT, resulting in index corruption. This patch release adds a single line of code to fix the problem."

https://www.sqlite.org/releaselog/3_8_10_2.html

"Fix an index corruption issue introduced by version 3.8.7. An index with a TEXT key can be corrupted by an INSERT into the corresponding table if the table has two nested triggers that convert the key value to INTEGER and back to TEXT again. Ticket 34cd55d68e0"

Comment 1

[D. Richard Hipp]

Just to be clear, the SQLite bug fixed in 3.8.10.2 should not affect FF and so this upgrade is not an emergency.

Comment 2

[Marco Bonardo [:mak]]

Yes, I don't think the databases we control can hit this specific case.
I don't know if indexedDB could hit it, but I don't think we have nested triggers there, as well.

We can take the update in Nightly without problems, I'd not uplift.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to Marco Bonardo [::mak] from comment #2)
> I don't know if indexedDB could hit it

I think IDB is unaffected also.

Comment 4

[Boaz Dodin]

This bug should probably depends on SQLite3.8.10.1, not block it.

Comment 5

[Arthur K. (he/him)]

Looks like 3.8.11 was released yesterday with some nice optimizations.

https://www.sqlite.org/releaselog/3_8_11.html