1166886 - [e10s] Exception in Prefetcher.jsm

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

I was testing some add-ons in Aurora and there's an exception that gets thrown when we call Cu.getJSTestingFunctions().objectAddress(), which is Nightly-only. It prevents the shims from working properly. How embarrassing.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8608300 [details] [diff] [review]
patch

This is a bug in some logging code that was supposed to be disabled anyway. It only causes trouble on Aurora because it uses a debugging function that's only enabled on Nightly. I think we should take this on Aurora ASAP since it causes a bunch of add-ons to be broken there when e10s is enabled.

Approval Request Comment
[Feature/regressing bug #]: bug 1102643
[User impact if declined]: Add-ons don't work on Aurora when e10s enabled.
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]: Very low. Just logging code.
[String/UUID change made/needed]: None.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6dfba2fa6c41

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/486709a9d6f8

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Somehow I forgot to land this on central. Anyway, now it's fixed on central and on the new aurora.
https://hg.mozilla.org/releases/mozilla-aurora/rev/305900080dba

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/486709a9d6f8