Closed Bug 1166886 Opened 4 years ago Closed 4 years ago

[e10s] Exception in Prefetcher.jsm

Categories

(Firefox :: Extension Compatibility, defect)

34 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
e10s + ---
firefox40 --- fixed
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
I was testing some add-ons in Aurora and there's an exception that gets thrown when we call Cu.getJSTestingFunctions().objectAddress(), which is Nightly-only. It prevents the shims from working properly. How embarrassing.
Attachment #8608300 - Flags: review?(mconley)
Summary: Exception in Prefetcher.jsm → [e10s] Exception in Prefetcher.jsm
Attachment #8608300 - Flags: review?(mconley) → review+
Comment on attachment 8608300 [details] [diff] [review]
patch

This is a bug in some logging code that was supposed to be disabled anyway. It only causes trouble on Aurora because it uses a debugging function that's only enabled on Nightly. I think we should take this on Aurora ASAP since it causes a bunch of add-ons to be broken there when e10s is enabled.

Approval Request Comment
[Feature/regressing bug #]: bug 1102643
[User impact if declined]: Add-ons don't work on Aurora when e10s enabled.
[Describe test coverage new/current, TreeHerder]: None.
[Risks and why]: Very low. Just logging code.
[String/UUID change made/needed]: None.
Attachment #8608300 - Flags: approval-mozilla-aurora?
Attachment #8608300 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Somehow I forgot to land this on central. Anyway, now it's fixed on central and on the new aurora.
https://hg.mozilla.org/releases/mozilla-aurora/rev/305900080dba
https://hg.mozilla.org/mozilla-central/rev/486709a9d6f8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Target Milestone: Firefox 41 → Firefox 42
You need to log in before you can comment on or make changes to this bug.