Closed Bug 1166921 Opened 9 years ago Closed 9 years ago

Support storage inspector stores-cleared event

Categories

(DevTools :: Storage Inspector, defect)

Product:
DevTools
Component:
Storage Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: harth, Assigned: ntim)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v1.1
2.54 KB, patch
ntim
: review+
Details | Diff | Splinter Review 
The localStorage inspector seems to update when keys are added to localStorage, but not when they're deleted. It would be great to have this to accurately reflect what's in localStorage.
I can't reproduce (on latest Nightly at least), do you have a testcase ?
Flags: needinfo?(fayearthur)
Looks like localStorage.clear() isn't supported.
Flags: needinfo?(fayearthur)
Summary: Update localStorage inspector when a key is deleted → Support storage inspector stores-cleared event
Attached patch Patch (obsolete) — — Splinter Review 
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED

        Attachment #8647463 -
        Flags: review?(mratcliffe)

    
  
Depends on: 1194190

    
  
Blocks: 1194190
No longer depends on: 1194190

        Attachment #8647463 -
        Flags: review?(mratcliffe) → review+

    
  
Depends on: 1195135

    
    

    
  
Tests will be added in bug 1195135 since they await the e10s test refactor in bug 1175850.
Keywords: checkin-needed

    
  
Keywords: checkin-needed

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1.1
        — 
          — Splinter Review
      

    


  
Forgot to remove the event listener on destroy in previous iteration.

        Attachment #8647463 -
        Attachment is obsolete: true

        Attachment #8648527 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/698d20c94746
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox43:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: