1167014 - Appropriately ignore deleted history items

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

We ignore them in the UI right now because we blow away all of their visits, and we don't show unvisited sites. Great!

But for thoroughness, we should make two changes:

Firstly, SQLiteHistory.getFilteredSitesWithLimit should explicitly ignore deleted sites.

Secondly, SQLiteHistory.recordVisitedSite sets is_deleted to 0, but doesn't change the GUID.

This is an area of undefined behavior in Sync. For example, a user could:

1. Add some visits. A GUID is assigned.
2. Delete the history item.
3. Add some more visits. The GUID is preserved.
4. Sync.

or:

1. Add some visits. A GUID is assigned.
2. Sync.
3. Delete the history item.
4. Add some more visits. The GUID is preserved.
5. Sync.

Same user action, different end state: in the former, only the visits added in (3) escape; in the latter, both sets of visits escape.

But what else can we do? We could switch GUIDs, but then the other clients will unify on URL, and *their* final behavior depends on the order in which they receive the records:

1. Deleted first, new GUID second: only new visits preserved.
2. New GUID first, deleted second: all visits preserved, because the deletion doesn't apply after the GUID remap.

We should think more about this.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull req.

Tail-end of this PR.

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8608878 [details] [review]
Pull req.

wfm.

Comment 3

[Richard Newman [:rnewman]]

110264a