Closed Bug 1167049 Opened 10 years ago Closed 8 years ago

In setDefaultRoute, new & old interface name could be same

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: swu, Unassigned)

References

Details

In setDefaultRoute, it passes old interface name(if exists) to remove the old default route. https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkService.js#403 In some condition, it is possible to have same new & old interface names. This results in removing and setting default route on same interface name. It happens when network & oldInterface are different objects but having same interface name. Not sure whether this is under expectation, but in such condition, it could hit bug 1167028.
I found this when working on test cases in bug 1000040. The condition to reproduce the problem is like below, where network1 and network2 are different objects but have same interface name(eth1). 1. gNetworkManager.registerNetworkInterface(network1) 2. gNetworkManager.updateNetworkInterface(network1) // gNetworkManager.active is set to network1 3. gNetworkManager.unregisterNetworkInterface(network1) // gNetworkManager.active not cleared! 4. gNetworkManager.registerNetworkInterface(network2) 5. gNetworkManager.updateNetworkInterface(network2) // gNetworkManager.active is set to network2 and gNetworkManager.oldActive is set to network1 Probably it's a bug in NetworkManager or I missed something.
Depends on: 1167054
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.