1167050 - Can't choose the time in datetime and datetime-local input element.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Mantaroh Yoshinaga[:mantaroh]]

When choosed the datetime and datetime-local input element,
I can choose the date, but can't choose the time.

Reproduce Step:
1) Open browser app.
2) Open the datetime /datetime-local samplepage.[1]
3) Tap the datetime / datetime-local element.
4) select date, and [OK] tap

Actual Result:
 don't show the time picker dialog.

Expected Result:
 show the time picker dialog.

[1] http://jsbin.com/bifami

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

It seems occurred due to value_selector element is hidden.

The picker container(contain timepicker / datepicker) has hidden when tap the [OK] button in date picker dialog.[1].

And timepicker visibility is false when called showTimePicker().[2]
But container is invisible..

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/value_selector/value_selector.js#L405
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/value_selector/value_selector.js#L508

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mantaroh:master > mozilla-b2g:master

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8608553 [details] [review]
[gaia] mantaroh:master > mozilla-b2g:master

Hi alive,

I created the Pull Request this bugs.
could you please review this change?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8608553 [details] [review]
[gaia] mantaroh:master > mozilla-b2g:master

Thanks for contributing!
Bypass this review to Rudy. BTW, it's better having unit test.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8608553 [details] [review]
[gaia] mantaroh:master > mozilla-b2g:master

Thanks for your help to fix this issue.
As Alive mentioned, it would be good to add unit test for this case.

The code lives in,
apps/system/test/unit/value_selector_test.js

If you don't know how to do that, it is ok, I'll handle that as a follow-up.

Comment 6

[Mantaroh Yoshinaga[:mantaroh]]

Hi rudy.

THank you for review this bug.

> Thanks for your help to fix this issue.
> As Alive mentioned, it would be good to add unit test for this case.
> 
> The code lives in,
> apps/system/test/unit/value_selector_test.js
> 
> If you don't know how to do that, it is ok, I'll handle that as a follow-up.
OK.
I submitted bug #1167813.

Comment 7

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 8

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Land this manually because I am not one of the suggested reviewer of system app.

Gaia master,
https://github.com/mozilla-b2g/gaia/commit/3f38f429cfd5d1260362d7fb3fbf52576bbec83b

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I think this is another regression caused by bug 962434, so this will affect both v2.1 and v2.2.
Will ask approval to see if we can get this fix in for those branches.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8608553 [details] [review]
[gaia] mantaroh:master > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 962434
[User impact] if declined: Cannot use our built-in value selector for input with type=datetime or datetime-local, though I'm not sure how many web pages have been using this kind of inputs. 
[Testing completed]: Yes, manually.
[Risk to taking this patch] (and alternatives if risky): Should be low, the fix here is simply a one-line fix to correct the UI show/hiding flow.
[String changes made]: N/A

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Mark the follow-up bug as dependency.

Comment 13

[Josh Cheng [:josh]]

Comment on attachment 8608553 [details] [review]
[gaia] mantaroh:master > mozilla-b2g:master

Approving regression issue.
Requesting QA verifyme after patch land on 2.1 and 2.2

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/d03cd5c762e1993308e8d061510fa155039e6550
v2.1: https://github.com/mozilla-b2g/gaia/commit/2304a1f6327c2ccf35d6995ee16f2231ed1f22a3

Comment 15

[helen（leave from Mozilla）]

Attachment: v3.0.mp4

This bug has been verified as Pass on latest build of Flame v3.0 & Nexus 5 v3.0 by the STR in Comment 0. 

Results:
After choosing data and tapping OK, the time picker dialog shows.

See attachment: v3.0.mp4
Reproduce rate: 0/15

Device: Flame v3.0(Pass)
Build ID               20150526160204
Gaia Revision          8ca93673869a64e09ed6153c5402896822dfb253
Gaia Date              2015-05-26 19:31:37
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1e4e369822ac
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150526.195035
Firmware Date          Tue May 26 19:50:45 EDT 2015
Bootloader             L1TC000118D0


Device: Nexus 5 v3.0(Pass)
Build ID               20150526160204
Gaia Revision          8ca93673869a64e09ed6153c5402896822dfb253
Gaia Date              2015-05-26 19:31:37
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1e4e369822ac
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150526.195039
Firmware Date          Tue May 26 19:50:56 EDT 2015
Bootloader             HHZ12f

Comment 16

[helen（leave from Mozilla）]

Attachment: v2.1.3gp

This bug has been verified as pass on latest build of Flame v2.1 & v2.2 and v2.1s_512mb and Nexus 5 v2.2 by the STR in Comment 0. 

Results:
After choosing data and tapping OK, the time picker dialog shows.

Attachment:v2.1.3gp
Rate:0/20

Device:Flame v2.1(Verified)
Build ID               20150622001205
Gaia Revision          f8b848c82d1ed589f7a1eb5cc099830c867ff1d4
Gaia Date              2015-06-08 09:48:23
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ed778b596fad
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150622.035118
Firmware Date          Mon Jun 22 03:51:29 EDT 2015
Bootloader             L1TC000118D0

Device:Flame v2.2(Verified)
Build ID               20150619002501
Gaia Revision          1c33072e33c279c8aa5cb5e4a3e4da6af6cd818b
Gaia Date              2015-06-19 01:36:47
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5ad34a170633
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150619.042950
Firmware Date          Fri Jun 19 04:30:02 EDT 2015
Bootloader             L1TC000118D0

Device: v2.1s_512mb(Verified)
Build ID               20150622001204
Gaia Revision          4196ca9119b4cde8353130165de90c0ffa6060a3
Gaia Date              2015-06-17 03:30:30
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/6299ba592af4
Gecko Version          34.0
Device Name            scx15_sp7715ea
Firmware(Release)      4.4.2
Firmware(Incremental)  122
Firmware Date          Thu Feb  5 12:42:58 CST 2015

Device: Nexus5 v2.2 (Verified)
Build ID               20150621002506
Gaia Revision          1f8981d7872e3c0053571c26fb3edaf401844d75
Gaia Date              2015-06-19 13:22:30
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/9a0d8f7b1200
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150621.035418
Firmware Date          Sun Jun 21 03:54:36 EDT 2015
Bootloader             HHZ12f