1167077 - Disable all System app's audio channels when AudioChannelService is initializing.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)

Description

[Evan Tseng [:evanxd]]

In shell.js[1], the System app's audio channels is allowed to play by default for playing any audio before the AudioChannelService[2] is loaded. But for managing the audio channels correctly, we need to disable them after AudioChannelService is loaded.

[1]: Bug 1165134 - Add new MozChromeEvent/MozContentEvent to allow System app to control its own audio channels
[2]: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/audio_channel_service.js

Comment 1

[Evan Tseng [:evanxd]]

Update:

Let's disable the audio channels in SystemWindow[1]. It more makes sense.

[1]: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/system_window.js

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] evanxd:bug-1167077 > mozilla-b2g:master

Comment 3

[Evan Tseng [:evanxd]]

If CI[1] is good, then let's start to review the patch. :)

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=bb7676e16e8bb1bfc94c2ed90b943f59c54b9473

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8608550 [details] [review]
[gaia] evanxd:bug-1167077 > mozilla-b2g:master

Hi Alive and Dominic,

Could you review the patch?

Thanks.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8608550 [details] [review]
[gaia] evanxd:bug-1167077 > mozilla-b2g:master

Telling gecko to mute the audio when SystemWindow being started is not a correct timing to me. We should wait AudioChannelManager to start. Otherwise nobody could manage the audioChannels.

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 8608550 [details] [review]
[gaia] evanxd:bug-1167077 > mozilla-b2g:master

Same reason as Alive's comment so cancelling the review. Evan, let's have a discussion again about the system's audio channel issue before the system app actually started after you got back.

Comment 7

[Evan Tseng [:evanxd]]

Patch[1] is updated. Let's add tests.

[1]: https://github.com/evanxd/gaia/commit/194c7873c37af944992c685038a16f46c3f13919

Comment 8

[Evan Tseng [:evanxd]]

Tests are added, and wait for the CI result[1]. If it is good, let's start to review the patch again.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=201476131284a8a44fce4eafdddf13c029116a88

Comment 9

[Evan Tseng [:evanxd]]

The patch: https://github.com/evanxd/gaia/commit/201476131284a8a44fce4eafdddf13c029116a88 for Comment 8.

Comment 10

[Evan Tseng [:evanxd]]

Patch is updated: https://github.com/evanxd/gaia/commit/940cc1e559817bd0ed4ef3fe45185c8d26dbab32

The CI: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=940cc1e559817bd0ed4ef3fe45185c8d26dbab32

Comment 11

[Evan Tseng [:evanxd]]

Comment on attachment 8608550 [details] [review]
[gaia] evanxd:bug-1167077 > mozilla-b2g:master

Hi Alive,

Patch is updated.
Could you help to review it again?

Thanks.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8608550 [details] [review]
[gaia] evanxd:bug-1167077 > mozilla-b2g:master

r+ with nits

Comment 13

[Evan Tseng [:evanxd]]

Alvie, thanks for the review.

Comment 14

[Evan Tseng [:evanxd]]

Update the patch[1] for the nits and wait for the CI. If CI is good, let's land the code. :D

[1]: https://github.com/evanxd/gaia/commit/462e89a6505e4bb32fca52111946cee709c45424
[2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=462e89a6505e4bb32fca52111946cee709c45424

Comment 15

[Evan Tseng [:evanxd]]

Added new tests[1] and wait the CI[2].

[1]: https://github.com/evanxd/gaia/commit/bd7463d389a78c6fb36ca358a428f0db66f86d01
[2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=bd7463d389a78c6fb36ca358a428f0db66f86d01

Comment 16

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/bc730eae6a2489a2b5c345b838bb7a1dae9c6477