1167166 - about:telemetry: "Week" and "Ping" are not localizable when displaying archived pings

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Francesco Lodolo [:flod]]

http://hg.mozilla.org/mozilla-central/file/faeecf37a482/toolkit/content/aboutTelemetry.xhtml#l70

In Telemetry Data, "Week" and "Ping" are hard-coded when switching to Archived pings.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Attachment: 'Week' and 'Ping' are not localizable in about:telemetry when displaying archived pings

Thanks for the heads-up Francesco.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/30e3f33e3255

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/30e3f33e3255

Comment 4

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8608666 [details] [diff] [review]
'Week' and 'Ping' are not localizable in about:telemetry when displaying archived pings

Approval Request Comment
[Feature/regressing bug #]:
Unified Telemetry, https://wiki.mozilla.org/Unified_Telemetry
This is part of the first (main) batch of uplifts to 40 to enable shipping on that train, see bug 1120356, comment 2.
[User impact if declined]:
Data & measurement insight projects delayed or blocked with direct impact on projects depending on this.
[Describe test coverage new/current, TreeHerder]:
We have good automation coverage of the feature.
We also had manual tests of the main tasks as well as confirmation of correct behavior on Nightly for the patches here.
[Risks and why]:
Low-risk - these patches are rather isolated to Telemetry and have been on Nightly for a while with no bad reports.
We intend to track on-going data quality and other issues during the 40 aurora & beta and flip the new behavior off when it doesn't meet the requirements.
[String/UUID change made/needed]:
The only string changes were to the about:telemetry page.
We decided that we can live with missing translations on that page for a cycle as that page is not exactly user-facing.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Georg Fritzsche [:gfritzsche] from comment #4)
> [String/UUID change made/needed]:
> The only string changes were to the about:telemetry page.
> We decided that we can live with missing translations on that page for a
> cycle as that page is not exactly user-facing.

While I'm not completely sure why this can't ride the trains (but that's up to release drivers to decide), for Aurora you should do a patch that doesn't touch aboutTelemetry.dtd and hard-code the string in the XHTML file to avoid creating unnecessary noise in string frozen branches.

Comment 6

[Georg Fritzsche [:gfritzsche]]

Ah, thanks, i didn't know - will fix that.

Comment 7

[Georg Fritzsche [:gfritzsche]]

(In reply to Francesco Lodolo [:flod] from comment #5)
> While I'm not completely sure why this can't ride the trains

FWIW:
* Unified Telemetry blocks other works and we are shooting for Fx40
* the about:telemetry changes enable inspecting/QAing/... the new Telemetry data