1167237 - Stop using nsIBrowserGlue.sanitize()

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Marco Bonardo [:mak]]

So, there are 3 callpoints using nsIBrowserGlue.sanitize(),

http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/privacy.js
http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/privacy.js
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#113

What's the best option here?
I think our best bet is to convert sanitize.js to sanitize.jsm... we can still retain a sanitize.js for add-ons compatibility, it will warn deprecation.

once we have the module, fixing the callpoints should be trivial.

I will file a dependency to do the module conversion, then we can convert consumers in other future dependencies
http://mxr.mozilla.org/mozilla-central/search?string=sanitize.js

note: this is not yet mentor-able cause we first need the dependencies.

Comment 1

[Marco Bonardo [:mak]]

This is actionable now.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1167237 - Remove nsIBrowserGlue.sanitize() and nsIBrowserGlue.

Review commit: https://reviewboard.mozilla.org/r/218070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218070/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8948666 [details]
Bug 1167237 - Remove nsIBrowserGlue.sanitize() and nsIBrowserGlue.

https://reviewboard.mozilla.org/r/218070/#review223958

Yay, cleanups!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4a3c7452fa4
Remove nsIBrowserGlue.sanitize() and nsIBrowserGlue. r=johannh

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a4a3c7452fa4