Closed Bug 1167274 Opened 6 years ago Closed 6 years ago

Some failures in PeerConnectionMedia::OnProxyAvailable will prevent ICE gathering from starting

Categories

(Core :: WebRTC: Networking, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(1 file, 1 obsolete file)

Any failure in the block here will prevent ICE gathering from starting, when they should only prevent an HTTP proxy from being set:

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp?from=PeerConnectionMedia.cpp&case=true#167

None of these failure cases look like they should ever happen, but we should fix to be sure.
Attached file MozReview Request: bz://1167274/bwc (obsolete) —
/r/9193 - Bug 1167274: Do the right thing when accessing the proxyinfo fails for some reason.

Pull down this commit:

hg pull -r e6b47efc5cfe6ea7292e143615d69137aef6103d https://reviewboard-hg.mozilla.org/gecko/
Attachment #8608854 - Flags: review?(martin.thomson)
Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

https://reviewboard.mozilla.org/r/9191/#review7857

::: media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.h:408
(Diff revision 1)
> +    void SetProxyOnPcm(nsIProxyInfo& proxyinfo);

This can be private.

::: media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp:185
(Diff revision 1)
> +    nsIProxyInfo& proxyinfo)

const?
Attachment #8608854 - Flags: review?(martin.thomson)
Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

https://reviewboard.mozilla.org/r/9191/#review7859

Ship It!
Attachment #8608854 - Flags: review+
https://reviewboard.mozilla.org/r/9191/#review7867

> const?

Sadly no. The getters aren't const.
Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

/r/9193 - Bug 1167274: Do the right thing when accessing the proxyinfo fails for some reason. r=mt

Pull down this commit:

hg pull -r 4208224d72467f322cf6e437ee14c5613f6c4984 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8608854 - Flags: review+
Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

Carry forward r=mt
Attachment #8608854 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6ce67a06c9a9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Attachment #8608854 - Attachment is obsolete: true
Attachment #8620349 - Flags: review+
You need to log in before you can comment on or make changes to this bug.