1167274 - Some failures in PeerConnectionMedia::OnProxyAvailable will prevent ICE gathering from starting

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P4)

Description

[Byron Campen [:bwc]]

Any failure in the block here will prevent ICE gathering from starting, when they should only prevent an HTTP proxy from being set:

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp?from=PeerConnectionMedia.cpp&case=true#167

None of these failure cases look like they should ever happen, but we should fix to be sure.

Comment 1

[Byron Campen [:bwc]]

Attachment: MozReview Request: bz://1167274/bwc

/r/9193 - Bug 1167274: Do the right thing when accessing the proxyinfo fails for some reason.

Pull down this commit:

hg pull -r e6b47efc5cfe6ea7292e143615d69137aef6103d https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

https://reviewboard.mozilla.org/r/9191/#review7857

::: media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.h:408
(Diff revision 1)
> +    void SetProxyOnPcm(nsIProxyInfo& proxyinfo);

This can be private.

::: media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp:185
(Diff revision 1)
> +    nsIProxyInfo& proxyinfo)

const?

Comment 3

[Martin Thomson [:mt:]]

Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

https://reviewboard.mozilla.org/r/9191/#review7859

Ship It!

Comment 4

[Byron Campen [:bwc]]

https://reviewboard.mozilla.org/r/9191/#review7867

> const?

Sadly no. The getters aren't const.

Comment 5

[Byron Campen [:bwc]]

Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

/r/9193 - Bug 1167274: Do the right thing when accessing the proxyinfo fails for some reason. r=mt

Pull down this commit:

hg pull -r 4208224d72467f322cf6e437ee14c5613f6c4984 https://reviewboard-hg.mozilla.org/gecko/

Comment 6

[Byron Campen [:bwc]]

Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

Carry forward r=mt

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ce67a06c9a9

Comment 8

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/6ce67a06c9a9

Comment 10

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1167274: Do the right thing when accessing the proxyinfo fails for some reason. r=mt