Some failures in PeerConnectionMedia::OnProxyAvailable will prevent ICE gathering from starting

RESOLVED FIXED in Firefox 41

Status

()

Core
WebRTC: Networking
P4
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bwc, Assigned: bwc)

Tracking

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Any failure in the block here will prevent ICE gathering from starting, when they should only prevent an HTTP proxy from being set:

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp?from=PeerConnectionMedia.cpp&case=true#167

None of these failure cases look like they should ever happen, but we should fix to be sure.
(Assignee)

Comment 1

2 years ago
Created attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

/r/9193 - Bug 1167274: Do the right thing when accessing the proxyinfo fails for some reason.

Pull down this commit:

hg pull -r e6b47efc5cfe6ea7292e143615d69137aef6103d https://reviewboard-hg.mozilla.org/gecko/
(Assignee)

Updated

2 years ago
Attachment #8608854 - Flags: review?(martin.thomson)
Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

https://reviewboard.mozilla.org/r/9191/#review7857

::: media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.h:408
(Diff revision 1)
> +    void SetProxyOnPcm(nsIProxyInfo& proxyinfo);

This can be private.

::: media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp:185
(Diff revision 1)
> +    nsIProxyInfo& proxyinfo)

const?
Attachment #8608854 - Flags: review?(martin.thomson)
Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

https://reviewboard.mozilla.org/r/9191/#review7859

Ship It!
Attachment #8608854 - Flags: review+
(Assignee)

Comment 4

2 years ago
https://reviewboard.mozilla.org/r/9191/#review7867

> const?

Sadly no. The getters aren't const.
(Assignee)

Comment 5

2 years ago
Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

/r/9193 - Bug 1167274: Do the right thing when accessing the proxyinfo fails for some reason. r=mt

Pull down this commit:

hg pull -r 4208224d72467f322cf6e437ee14c5613f6c4984 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8608854 - Flags: review+
(Assignee)

Comment 6

2 years ago
Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc

Carry forward r=mt
Attachment #8608854 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ce67a06c9a9
Keywords: checkin-needed

Comment 8

2 years ago
https://hg.mozilla.org/mozilla-central/rev/6ce67a06c9a9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Assignee)

Comment 9

2 years ago
Comment on attachment 8608854 [details]
MozReview Request: bz://1167274/bwc
Attachment #8608854 - Attachment is obsolete: true
Attachment #8620349 - Flags: review+
(Assignee)

Comment 10

2 years ago
Created attachment 8620349 [details]
MozReview Request: Bug 1167274: Do the right thing when accessing the proxyinfo fails for some reason. r=mt
You need to log in before you can comment on or make changes to this bug.