1167335 - Make manifest obtainer use Task.jsm

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Marcos Caceres [:marcosc]]

Manifest obtainer is highly asynchronous, hence it would benefit (if only in legibility) from using Task.jsm.

Comment 1

[Marcos Caceres [:marcosc]]

Attachment: Using Task.js makes code a bit cleaner.

Comment 2

[(no longer active)]

Comment on attachment 8610254 [details] [diff] [review]
Using Task.js makes code a bit cleaner.

I'm not familiar with Task.jsm.  I think you should ask someone who knows how to use that code.  It's typically used by front-end, AFAIK.

Comment 3

[Marcos Caceres [:marcosc]]

Comment on attachment 8610254 [details] [diff] [review]
Using Task.js makes code a bit cleaner.

Dave, can you please check my usage of Task.jsm?

Comment 4

[Marcos Caceres [:marcosc]]

Attachment: Fixed small bug (forgot to set response.success to false in manifestMessages.js)

Comment 5

[Marcos Caceres [:marcosc]]

Try: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=278a138feef3

Comment 6

[Marcos Caceres [:marcosc]]

New Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e949fe7daa8

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41a8951e52d6

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/41a8951e52d6