Closed Bug 1167335 Opened 5 years ago Closed 5 years ago

Make manifest obtainer use Task.jsm

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Manifest obtainer is highly asynchronous, hence it would benefit (if only in legibility) from using Task.jsm.
Assignee: nobody → mcaceres
Blocks: webmanifest
Summary: Be nice if manifest obtainer used Task.jsm → Make manifest obtainer use Task.jsm
Attachment #8610254 - Flags: review?(ehsan)
Comment on attachment 8610254 [details] [diff] [review]
Using Task.js makes code a bit cleaner.

I'm not familiar with Task.jsm.  I think you should ask someone who knows how to use that code.  It's typically used by front-end, AFAIK.
Attachment #8610254 - Flags: review?(ehsan)
Comment on attachment 8610254 [details] [diff] [review]
Using Task.js makes code a bit cleaner.

Dave, can you please check my usage of Task.jsm?
Attachment #8610254 - Flags: review?(dherman)
Attachment #8610254 - Flags: review?(dherman) → review?(oyiptong)
Attachment #8610254 - Attachment is obsolete: true
Attachment #8610254 - Flags: review?(oyiptong)
Attachment #8613065 - Flags: review?(oyiptong)
Attachment #8613065 - Flags: review?(oyiptong) → review+
https://hg.mozilla.org/mozilla-central/rev/41a8951e52d6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.