1167352 - Remember Password prompt blocking page load

Status: REOPENED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Report from Chris that loading into Facebook would not progress due to a modal Remember Password prompt

https://groups.google.com/a/mozilla.com/d/msg/ios-feedback/Tx3PwBoWeLA/qlZbDRfGoegJ

Anyone reproduce?

Comment 1

[Christopher Arnold]

I should probably clarify here.

What I saw was Login button not being as responsive as I expected.  I believe what happened was the keyboard was engaged while hiding a "save this password" prompt at the bottom of the page.

I navigated away to a different tab.  When I came back, login had processed and "save password" was still open at the bottom of that page.

I'm not sure if the save password confirmation actually caused a lag, or if I was just unable to see that a call to action was on the page.  

Might it be possible to put "save password" at the top of the page?

Photos of flow coming next.

Christopher

Comment 2

[Christopher Arnold]

Attachment: LoginButtonAppearsNonResponsiveButPromptHidden.PNG

First step, user visits a page they haven't entered yet to input a new login credential.

Crucial element here, the keyboard is covering a "Save this Password" prompt at the bottom of the page.  Is this the case?  Can the prompt be above the keyboard as an interstitial step?

Comment 3

[Christopher Arnold]

Attachment: SavePasswordPromptPersistingLater.PNG

After suspecting login failure and navigating to a new tab, I returned to the previous tab.  Prompt to save password that was hidden in the first step is now available to me.

Comment 4

[Wesley Johnston (:wesj)]

I'd be really surprised if this dialog was blocking anything. Usually, the keyboard will go away when you submit a form and this becomes visible.

Comment 5

[Christopher Arnold]

Attachment: PossibleBackgroundCauseOfLoginStall.png

I believe the cause of the issue in first attachment is this.  There was actually a hidden save password prompt beneath the keyboard in the first image.  If the user clicks "Done" on the keyboard before clicking "Log In" they should be able to see this.  However, because Log In is available above the keyboard already, a user will typically click directly on that, missing the save password prompt.

I'm not sure if this can be changed, or if we can do the save password prompt in a different way.

Comment 6

[Christopher Arnold]

(In reply to Wesley Johnston (:wesj) from comment #4)
> I'd be really surprised if this dialog was blocking anything. Usually, the
> keyboard will go away when you submit a form and this becomes visible.

The login wasn't blocked per se.  It was happening in the background.  First time login on a new device sometimes takes longer than a repeat login.  (As the service wants to validate the source of the login if on an unknown device.)  Because the progress bar in Fennec didn't show anything happening for a long time, my user error was just to presume that the button click wasn't working.

This probably isn't a mainstream use case on iPhones to use browsers to log into sites that also offer native apps.  So I'm not sure many people will notice this.

Comment 7

[Wesley Johnston (:wesj)]

I think this is probably related to showing feedback faster on taps:

https://bugzilla.mozilla.org/show_bug.cgi?id=1163284

but there's also a potential bug here about the keyboard. I'll file that...

Comment 8

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.