Closed Bug 1167378 Opened 5 years ago Closed 5 years ago

Mark ArrayAndPrefix as MOZ_STACK_CLASS and array member as MOZ_NON_OWNING_REF

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Blocks: 1114683
Attachment #8608996 - Flags: review?(nfroyd)
Comment on attachment 8608996 [details] [diff] [review]
use nsCOMPtr for array in ArrayAndPrefix and mark as MOZ_STACK_CLASS

Review of attachment 8608996 [details] [diff] [review]:
-----------------------------------------------------------------

+1 on MOZ_STACK_CLASS, -0 on using nsCOMPtr here.  I think it'd be better to mark it as MOZ_NON_OWNING_REF and move on.
Attachment #8608996 - Flags: review?(nfroyd) → feedback+
Comment on attachment 8612332 [details] [diff] [review]
use nsCOMPtr for array in ArrayAndPrefix and mark as MOZ_STACK_CLASS

Review of attachment 8612332 [details] [diff] [review]:
-----------------------------------------------------------------

r=me and please don't forget to change the commit message to match what the patch actually does. :)
Attachment #8612332 - Flags: review?(nfroyd) → review+
Fix the commit message
Attachment #8612332 - Attachment is obsolete: true
Assignee: nobody → michael
Keywords: checkin-needed
Summary: Use nsCOMPtr for array in ArrayAndPrefix and mark as MOZ_STACK_CLASS → Mark ArrayAndPrefix as MOZ_STACK_CLASS and array member as MOZ_NON_OWNING_REF
https://hg.mozilla.org/mozilla-central/rev/185ff4a22a39
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.