1167378 - Mark ArrayAndPrefix as MOZ_STACK_CLASS and array member as MOZ_NON_OWNING_REF

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=543afb1c8ebb

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: use nsCOMPtr for array in ArrayAndPrefix and mark as MOZ_STACK_CLASS

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8608996 [details] [diff] [review]
use nsCOMPtr for array in ArrayAndPrefix and mark as MOZ_STACK_CLASS

Review of attachment 8608996 [details] [diff] [review]:
-----------------------------------------------------------------

+1 on MOZ_STACK_CLASS, -0 on using nsCOMPtr here.  I think it'd be better to mark it as MOZ_NON_OWNING_REF and move on.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: use nsCOMPtr for array in ArrayAndPrefix and mark as MOZ_STACK_CLASS

new try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f448e2eccb8

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8612332 [details] [diff] [review]
use nsCOMPtr for array in ArrayAndPrefix and mark as MOZ_STACK_CLASS

Review of attachment 8612332 [details] [diff] [review]:
-----------------------------------------------------------------

r=me and please don't forget to change the commit message to match what the patch actually does. :)

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Mark ArrayAndPrefix as MOZ_STACK_CLASS and array member as MOZ_NON_OWNING_REF

Fix the commit message

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/185ff4a22a39

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/185ff4a22a39